Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Riku Voipio <riku.voipio@linaro.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] eglibc: Update SRC_URI and fix unpackaged empty dir
Date: Mon, 26 Aug 2013 11:45:52 +0200	[thread overview]
Message-ID: <20130826094552.GP3544@jama> (raw)
In-Reply-To: <CAAqcGHmnX+7CCZ9BS0s2Xut5DbuzSgu1h-a-bFsDo588iyi6dA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

On Mon, Aug 26, 2013 at 12:37:18PM +0300, Riku Voipio wrote:
> Hi,
> 
> On 21 August 2013 08:45, Khem Raj <raj.khem@gmail.com> wrote:
> > diff --git a/meta/recipes-core/eglibc/eglibc-package.inc b/meta/recipes-core/eglibc/eglibc-package.inc
> > index a590cce..1a23805 100644
> > --- a/meta/recipes-core/eglibc/eglibc-package.inc
> > +++ b/meta/recipes-core/eglibc/eglibc-package.inc
> > @@ -76,6 +76,10 @@ do_install_append () {
> >         rm -f ${D}${sysconfdir}/localtime
> >         rm -rf ${D}${localstatedir}
> >
> > +       # remove empty eglibc dir
> > +       if [ -d ${D}${libdir}/eglibc ]; then
> > +               rmdir ${D}${libdir}/eglibc
> > +       fi
> >         oe_multilib_header bits/syscall.h
> >
> >         if [ -f ${D}${bindir}/mtrace ]; then
> 
> This breaks in the case the directory exists and is not empty - which
> is the case when you build with eglibc-2.17. In that case there is a
> pt_chown binary. pt_chown is deprecated since devpts was invented, and
> now removed in 2.18.

Can we use just
rmdir --ignore-fail-on-non-empty ${D}${libdir}/eglibc
?

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  reply	other threads:[~2013-08-26  9:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21  5:45 [PATCH] eglibc: Update SRC_URI and fix unpackaged empty dir Khem Raj
2013-08-26  9:37 ` Riku Voipio
2013-08-26  9:45   ` Martin Jansa [this message]
2013-08-26 17:31     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130826094552.GP3544@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=riku.voipio@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox