From: Martin Jansa <martin.jansa@gmail.com>
To: Ross Burton <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] mesa: use distro_features_check to abort build without opengl feature
Date: Mon, 9 Sep 2013 14:08:24 +0200 [thread overview]
Message-ID: <20130909120824.GQ11500@jama> (raw)
In-Reply-To: <1378721952-10827-1-git-send-email-ross.burton@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
On Mon, Sep 09, 2013 at 11:19:11AM +0100, Ross Burton wrote:
> Stop mesa from building on distributions without the "opengl" DISTRO_FEATURE.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-graphics/mesa/mesa.inc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
> index 71fcabd..79605fa 100644
> --- a/meta/recipes-graphics/mesa/mesa.inc
> +++ b/meta/recipes-graphics/mesa/mesa.inc
> @@ -19,7 +19,9 @@ DEPENDS = "expat makedepend-native flex-native bison-native"
>
> PROVIDES = "virtual/libgl virtual/libgles1 virtual/libgles2 virtual/egl"
>
> -inherit autotools pkgconfig pythonnative gettext
> +inherit autotools pkgconfig pythonnative gettext distro_features_check
> +
> +REQUIRED_DISTRO_FEATURES = "opengl"
Is this really needed? I was building mesa in distro without opengl for
long time and was considering (probably incorrectly) opengl DISTRO_FEATURE more
like sign of proper hw GL libraries.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-09-09 12:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 10:19 [PATCH 1/2] mesa: use distro_features_check to abort build without opengl feature Ross Burton
2013-09-09 10:19 ` [PATCH 2/2] xf86-video-intel: allow builds without opengl, add more options Ross Burton
2013-09-09 12:08 ` Martin Jansa [this message]
2013-09-09 12:12 ` [PATCH 1/2] mesa: use distro_features_check to abort build without opengl feature Burton, Ross
2013-09-09 12:16 ` Burton, Ross
2013-09-09 12:27 ` Martin Jansa
2013-09-09 12:40 ` Nicolas Dechesne
2013-09-09 13:17 ` Burton, Ross
2013-09-09 13:50 ` Nicolas Dechesne
2013-10-23 8:53 ` Nicolas Dechesne
2013-10-23 9:00 ` Burton, Ross
2013-10-23 9:25 ` Nicolas Dechesne
2013-10-23 12:14 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909120824.GQ11500@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox