Re: [PATCH 1/2] base: improve PACKAGECONFIG handling logic

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1469 bytes --]

On Tue, Sep 10, 2013 at 06:17:27PM +0100, Burton, Ross wrote:
> On 10 September 2013 18:15, Ross Burton <ross.burton@intel.com> wrote:
> > -                if num >= 3 and items[2]:
> > -                    extradeps.append(items[2])
> > -                if num >= 4 and items[3]:
> > -                    extrardeps.append(items[3])
> > -                if num >= 1 and items[0]:
> > -                    extraconf.append(items[0])
> > +                if items:
> > +                    extraconf.append(items.pop(0))
> > +                # Skip over disable
> > +                if items:
> > +                    items.pop(0)
> > +                if items:
> > +                    extradeps.append(items.pop(0))
> > +                if items:
> > +                    extrardeps.append(items.pop(0))
> 
> I should note that in a PACKAGECONFIG[foo] such as ",,,foo" this will
> add some whitespace to EXTRA_OECONF and DEPENDS.  If this is a massive
> concern I can sort it, but the clear code trumps the odd extra
> whitespace in my mind.

EXTRA_OECONF/DEPENDS space will probably force do_compile/do_install
tasks to execute again, while RDEPENDS/RRECOMMENDS only PACKAGECONFIGs
could be enabled with only do_package re-executed.

I don't know how many PACKAGECONFIG options we have without first 3
parameters, but in your example with foo it would be significant change.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]