From: Martin Jansa <martin.jansa@gmail.com>
To: Qi.Chen@windriver.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] update-rc.d.bbclass: change RRECOMMENDS to RDEPENDS
Date: Thu, 12 Sep 2013 12:25:03 +0200 [thread overview]
Message-ID: <20130912102503.GY11500@jama> (raw)
In-Reply-To: <4802511117bc648d9cd10d8262645069d9db1317.1378978986.git.Qi.Chen@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1932 bytes --]
On Thu, Sep 12, 2013 at 05:43:55PM +0800, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> If a package inherits update-rc.d.bbclass, it actually needs it to
> update the symlinks under /etc/rc?.d/ directories. This is a runtime
> dependency. For example, if we try to upgrade the dropbear on target,
> its postinst process will need the update-rc.d utility available,
> otherwise, the upgrade process will fail.
>
> Besides, if we only recommend update-rc.d, the do_rootfs process will
> fail once NO_RRECOMMENDATIONS is enabled. Because in OE, we try to do
> the postinsts at rootfs time.
IIRC it was changed to allow systemd images to be built completely
without update-rc.d (with BAD_RECOMMENDATIONS += "update-rc.d") and it's
IMHO still valid use-case as update-rc.d is inherited even when systemd
is used.
>
> This patch fixes this problem by changing the RRECOMMENDS to RDEPENDS
> to let the packages actually rdepend on update-rc.d.
>
> [YOCTO #5169]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> meta/classes/update-rc.d.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/update-rc.d.bbclass b/meta/classes/update-rc.d.bbclass
> index 5588569..3dee13a 100644
> --- a/meta/classes/update-rc.d.bbclass
> +++ b/meta/classes/update-rc.d.bbclass
> @@ -6,7 +6,7 @@ UPDATERCD_virtclass-cross = ""
> UPDATERCD_class-native = ""
> UPDATERCD_class-nativesdk = ""
>
> -RRECOMMENDS_${UPDATERCPN}_append = " ${UPDATERCD}"
> +RDEPENDS_${UPDATERCPN}_append = " ${UPDATERCD}"
>
> INITSCRIPT_PARAMS ?= "defaults"
>
> --
> 1.7.9.5
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-09-12 10:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 9:43 [PATCH 0/1] update-rc.d.bbclass: change RRECOMMENDS to RDEPENDS Qi.Chen
2013-09-12 9:43 ` [PATCH 1/1] " Qi.Chen
2013-09-12 10:25 ` Martin Jansa [this message]
2013-09-12 11:18 ` ChenQi
2013-09-12 12:18 ` Martin Jansa
2013-09-13 1:53 ` ChenQi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912102503.GY11500@jama \
--to=martin.jansa@gmail.com \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox