Re: [v2 PATCH 4/7] syslinux.bbclass, syslinux: Update to syslinux 6.01

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2682 bytes --]

On Mon, Sep 16, 2013 at 11:10:17AM -0700, Darren Hart wrote:
> On Sat, 2013-09-14 at 15:16 +0200, Martin Jansa wrote:
> > On Sat, Sep 14, 2013 at 07:19:43AM -0500, Jason Wessel wrote:
> > > On 09/14/2013 03:05 AM, Martin Jansa wrote:
> > > > On Fri, Sep 13, 2013 at 07:09:00PM -0500, Jason Wessel wrote:
> > > >> A newer version of syslinux is required for an EFI enabled isohybrid.
> > > >> This is used for the the capability to generate 3 types of ISO images,
> > > >> all of which can be booted off a USB device or HDD if copied with dd.
> > > >>
> > > >> 1) PC BIOS only ISO
> > > >> 2) EFI only ISO
> > > >> 3) EFI + PC BIOS ISO
> > > >>
> > > >> The syslinux.bbclass required a minor tweak because ldlinux.c32 is
> > > >> dynamically loaded and needs to be in the created media as of syslinux
> > > >> 5 and up.
> > > >
> > > > Hi Jason,
> > > >
> > > > can you please look at
> > > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=3944
> > > > ?
> > > 
> > > 
> > > I can look at fixing the defect, but there is no description of how to use the directdisk to see the problem.  Could you provide an example?
> > > 
> > > I added the directdisk to IMAGE_FSTYPES, but didn't get a .directdisk in the deploy directory so that is not how it works.   Also I think the right solution is to simply call syslinux_hddimg_populate() from the directdisk class vs having copied code for the install of the syslinux specific files (that is how 1/2 the problem occurred in the first place).
> > > 
> > > Back to this particular patch, the ldlinux.c32 change does not affect the bootdirect class.  The ldlinux.c32 is only required for isolinux and the copy is contained with in the inherited syslinux class.
> > 
> > You can reproduce it by adding vmdk to IMAGE_FSTYPES and building e.g.
> > qemux86 and trying to boot it in VirtualBox.
> > 
> > It will always enable tty0 and only way to disable it now is to enable
> > menu, but that doesn't work with vmdk images because of missing
> > vesamenu.c32
> > 
> 
> Thanks for catching that Martin.
> 
> I agree that the SYSLINUX_SERIAL needs to be respected regardless of if
> menu is set.

Yes, that would preserve existing behavior, not everybody wants to
have menu.

> It should be acceptable to install vesamenu.c32 I would think, although
> it sounds as though there is some work to perform to make sure
> bootdirect uses all the new infrastructure as well.

Yes it would be nice to have the possibility to enable menu, it can even
be enabled by default once it's working properly and there is an option
to disable it.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]