From: Denys Dmytriyenko <denis@denix.org>
To: "Franklin S. Cooper Jr" <fcooper@ti.com>
Cc: Darren Hart <dvhart@linux.intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [for dylan][PATCH] kernel.bbclass: Correct post(inst|rm) package association
Date: Fri, 04 Oct 2013 14:41:16 -0400 [thread overview]
Message-ID: <20131004184116.GA8393@denix.org> (raw)
In-Reply-To: <1380045500-10798-1-git-send-email-fcooper@ti.com>
Ping. Is Dylan still alive?
On Tue, Sep 24, 2013 at 12:58:20PM -0500, Franklin S. Cooper Jr wrote:
> From: Darren Hart <dvhart@linux.intel.com>
>
> Fixes [YOCTO #4991]
>
> The kernel image is installed as part of the kernel-image package, but
> the symlink creation/removal via alternatives is being done in
> pkg_post(inst|rm)_kernel-base.
>
> Move the postinst alternatives logic into the kernel-image functions.
>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> meta/classes/kernel.bbclass | 29 +++++++++++++----------------
> 1 files changed, 13 insertions(+), 16 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 3320747..c417038 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -237,14 +237,6 @@ do_savedefconfig() {
> do_savedefconfig[nostamp] = "1"
> addtask savedefconfig after do_configure
>
> -pkg_postinst_kernel-base () {
> - update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
> -}
> -
> -pkg_postrm_kernel-base () {
> - update-alternatives --remove ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} || true
> -}
> -
> inherit cml1
>
> EXPORT_FUNCTIONS do_compile do_install do_configure
> @@ -272,14 +264,19 @@ ALLOW_EMPTY_kernel-modules = "1"
> DESCRIPTION_kernel-modules = "Kernel modules meta package"
>
> pkg_postinst_kernel-image () {
> -if [ ! -e "$D/lib/modules/${KERNEL_VERSION}" ]; then
> - mkdir -p $D/lib/modules/${KERNEL_VERSION}
> -fi
> -if [ -n "$D" ]; then
> - depmodwrapper -a -b $D ${KERNEL_VERSION}
> -else
> - depmod -a ${KERNEL_VERSION}
> -fi
> + update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
> + if [ ! -e "$D/lib/modules/${KERNEL_VERSION}" ]; then
> + mkdir -p $D/lib/modules/${KERNEL_VERSION}
> + fi
> + if [ -n "$D" ]; then
> + depmodwrapper -a -b $D ${KERNEL_VERSION}
> + else
> + depmod -a ${KERNEL_VERSION}
> + fi
> +}
> +
> +pkg_postrm_kernel-image () {
> + update-alternatives --remove ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} || true
> }
>
> PACKAGESPLITFUNCS_prepend = "split_kernel_packages "
> --
> 1.7.0.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2013-10-04 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 17:58 [for dylan][PATCH] kernel.bbclass: Correct post(inst|rm) package association Franklin S. Cooper Jr
2013-10-04 18:41 ` Denys Dmytriyenko [this message]
2013-10-04 22:56 ` Paul Eggleton
2013-10-11 9:33 ` Paul Eggleton
2013-10-11 19:42 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004184116.GA8393@denix.org \
--to=denis@denix.org \
--cc=dvhart@linux.intel.com \
--cc=fcooper@ti.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox