Re: [PATCH] qemu: fix nativesdk build without x11

["Eric Bénard" <eric@eukrea.com>]

Le Mon, 7 Oct 2013 12:34:02 +0100,
"Burton, Ross" <ross.burton@intel.com> a écrit :

> On 5 October 2013 11:11, Eric Bénard <eric@eukrea.com> wrote:
> > when x11 is not defined in DISTRO_FEATURES, there are no x11 headers
> > so True is not defined leading to :
> > | ui/sdl.c:62:8: warning: type defaults to 'int' in declaration of 'doing_grabs' [-Wimplicit-int]
> > |  static doing_grabs = True;
> > |         ^
> > | ui/sdl.c:62:22: error: 'True' undeclared here (not in a function)
> > |  static doing_grabs = True;
> > |                       ^
> 
> Does qemu on SDL on framebuffer actually work?  I'd assumed that
> people using qemu without x11 were using it without SDL, so maybe this
> is a bug in the build configuration for nativesdk.
> 
I'm not using qemu in the present case, I was simply building a sdk.

> A better fix would be to use 1/0 instead of True/False, I was assuming
> that SDL meant X was being used.
> 
that would also fix the problem.

Eric