From: Martin Jansa <martin.jansa@gmail.com>
To: Xufeng Zhang <xufeng.zhang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] kernel.bbclass: Delay rm_work to run after do_bundle_initramfs
Date: Thu, 31 Oct 2013 09:26:25 +0100 [thread overview]
Message-ID: <20131031082625.GE32015@jama> (raw)
In-Reply-To: <1383182680-20871-1-git-send-email-xufeng.zhang@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1680 bytes --]
On Thu, Oct 31, 2013 at 09:24:40AM +0800, Xufeng Zhang wrote:
> From: "Signed-off-by: Xufeng Zhang" <xufeng.zhang@windriver.com>
>
> Since kernel will build twice when we are trying to bundle kernel
> and initramfs together after commit 609d5a9ab("kernel.bbclass,
> image.bbclass: Implement kernel INITRAMFS dependency and bundling"),
> thus, the second building for kernel would fail if rm_work is done
> previously.
>
> To fix this problem, we need to delay the rm_work task for kernel
> to run after do_bundle_initramfs task.
>
> [YOCTO #5416]
>
> Signed-off-by: Xufeng Zhang <xufeng.zhang@windriver.com>
> ---
> meta/classes/kernel.bbclass | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index dedfab7..6154df0 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -29,6 +29,9 @@ python __anonymous () {
> image_task = d.getVar('INITRAMFS_TASK', True)
> if image_task:
> d.appendVarFlag('do_configure', 'depends', ' ${INITRAMFS_TASK}')
> +
> + if image or image_task:
> + d.appendVarFlag('do_rm_work', 'depends', " %s:do_bundle_initramfs" % d.getVar('PN', True))
> }
Why not add "before" param to addtask?
addtask bundle_initramfs after do_compile before do_build
could do the trick
> inherit kernel-arch deploy
> --
> 1.8.3.3
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-10-31 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 1:24 [PATCH] kernel.bbclass: Delay rm_work to run after do_bundle_initramfs Xufeng Zhang
2013-10-31 8:26 ` Martin Jansa [this message]
2013-11-01 1:10 ` Xufeng Zhang
2013-11-07 15:08 ` Enrico Scholz
2013-11-07 22:26 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031082625.GE32015@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=xufeng.zhang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox