Re: [PATCH 4/4] qemu: add bash and python to qemu's RDEPENDS

[Olof Johansson <olof.johansson@axis.com>]

On 13-11-22 07:25 +0100, Hongxu Jia wrote:
> Hi Saul,
> 
> The script could not be de-bashed,  it was made by create_wrapper
> which is bashism:
> Vim image/usr/bin/qemu-mips
> ...
> #! /bin/bash
> realpath=`readlink -fn $0`
> export QEMU_RESERVED_VA=0x0
> exec -a `dirname $realpath`/qemu-mips `dirname $realpath`/qemu-mips.real "$@"
> ...
> 
> The exec's -a option is bashism, so we need to add bash to RDEPENDS.

1) Is the wrapper still necessary?

The comment above the do_install_append in the recipe:

# The following fragment will create a wrapper for qemu-mips user emulation
# binary in order to work around a segmentation fault issue. Basically, by
# default, the reserved virtual address space for 32-on-64 bit is set to 4GB.
# This will trigger a MMU access fault in the virtual CPU. With this change,
# the qemu-mips works fine.
# IMPORTANT: This piece needs to be removed once the root cause is fixed!

2) More generally, is -a generally necessary when exec'ing like this? Can't
   this be solved in another way?

-- 
olofjn