From: Martin Jansa <martin.jansa@gmail.com>
To: Qi.Chen@windriver.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] image.bbclass: depends on virtual/kernel
Date: Fri, 22 Nov 2013 12:38:32 +0100 [thread overview]
Message-ID: <20131122113832.GC3708@jama> (raw)
In-Reply-To: <8403fc751bcf1e0b62b600ed40e00256963f357d.1385098685.git.Qi.Chen@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1852 bytes --]
On Fri, Nov 22, 2013 at 01:39:02PM +0800, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> Add 'virtual/kernel' to DEPENDS in image.bbclass so that the kernel
> can get built by default. Otherwise, the kernel will not get built
> unless it's required by other packages like v86d. As a result, if
> we build 'core-image-minimal' for qemumips, the kernel is not built,
> and we have 'bitbake linux-yocto' before we can use runqemu to start
> the target.
Even when it's not really build time requirement for images I understand
the scenario above and this seems like better place than packagegroup
where it was before.
My only concern is small initramfs images like
meta-initramfs/recipes-bsp/images/initramfs-kexecboot-image.bb:inherit image
which could in turn be DEPENDS of real virtual/kernel causing circular
dependency.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> meta/classes/image.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index bc60f0d..ccb6bf3 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -10,7 +10,7 @@ inherit gzipnative
>
> LICENSE = "MIT"
> PACKAGES = ""
> -DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross"
> +DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross virtual/kernel"
> RDEPENDS += "${PACKAGE_INSTALL} ${LINGUAS_INSTALL}"
> RRECOMMENDS += "${PACKAGE_INSTALL_ATTEMPTONLY}"
>
> --
> 1.7.9.5
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-11-22 11:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 5:39 [PATCH 0/1] image.bbclass: depends on virtual/kernel Qi.Chen
2013-11-22 5:39 ` [PATCH 1/1] " Qi.Chen
2013-11-22 11:38 ` Martin Jansa [this message]
2013-11-22 11:41 ` Phil Blundell
2013-11-22 12:06 ` Richard Purdie
2013-11-22 19:58 ` Otavio Salvador
2013-11-22 22:32 ` Andrea Adami
2013-11-25 12:09 ` ChenQi
2013-11-25 12:28 ` Otavio Salvador
2013-11-25 12:57 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131122113832.GC3708@jama \
--to=martin.jansa@gmail.com \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox