From: Martin Jansa <martin.jansa@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] image.bbclass: Depend on virtual/kernel:do_deploy
Date: Fri, 29 Nov 2013 16:38:56 +0100 [thread overview]
Message-ID: <20131129153856.GB2860@jama> (raw)
In-Reply-To: <1385735802.11222.62.camel@ted>
[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]
On Fri, Nov 29, 2013 at 02:36:42PM +0000, Richard Purdie wrote:
> Now that none of the packagegroups depend on virtual/kernel, we have the problem
> that MACHINE=qemumips bitbake core-image-minimal doesn't put a kernel
> into the deploy directory. This breaks many common usecases and
> user expectations.
>
> To avoid this, add a dependency on the kernel deploy to image do_build tasks.
> This should avoid any circular dependency issues but equally ensure users
> have their expectations met.
Acked-By: Martin Jansa <Martin.Jansa@gmail.com>
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 8217fb3..cc65e35 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -90,6 +90,8 @@ do_rootfs[depends] += "makedevs-native:do_populate_sysroot virtual/fakeroot-nati
> do_rootfs[depends] += "virtual/update-alternatives-native:do_populate_sysroot update-rc.d-native:do_populate_sysroot"
> do_rootfs[recrdeptask] += "do_packagedata"
>
> +do_build[depends] += "virtual/kernel:do_deploy"
> +
> def build_live(d):
> if base_contains("IMAGE_FSTYPES", "live", "live", "0", d) == "0": # live is not set but hob might set iso or hddimg
> d.setVar('NOISO', base_contains('IMAGE_FSTYPES', "iso", "0", "1", d))
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
prev parent reply other threads:[~2013-11-29 15:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 14:36 [PATCH] image.bbclass: Depend on virtual/kernel:do_deploy Richard Purdie
2013-11-29 15:38 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131129153856.GB2860@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox