Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Christopher Larson <kergoth@gmail.com>
Cc: Christopher Larson <chris_larson@mentor.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 7/7] pulseaudio: fix RDEPENDS traversal for consolekit
Date: Wed, 11 Dec 2013 22:22:54 +0100	[thread overview]
Message-ID: <20131211212254.GA3717@jama> (raw)
In-Reply-To: <c39555e418cf1bbb70e06dbe905411a864727e42.1385575572.git.kergoth@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2160 bytes --]

On Wed, Nov 27, 2013 at 11:07:07AM -0700, Christopher Larson wrote:
> From: Christopher Larson <chris_larson@mentor.com>
> 
> Include the console-kit module in PACKSGES explicitly so bitbake can map to
> the RDEPENDS we define for it in this recipe, and thereby ensure that when
> adding the console-kit module to an image, we also get the necessary
> consolekit package produced.
> 
> Signed-off-by: Christopher Larson <kergoth@gmail.com>
> ---
>  meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> index 7e87ef8..2bee9eb 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> @@ -69,8 +69,12 @@ USERADD_PARAM_pulseaudio-server = "--system --home /var/run/pulse \
>                                --no-create-home --shell /bin/false \
>                                --groups audio,pulse --gid pulse pulse"
>  
> +# The console-kit module is included here explicitly so bitbake can map to the
> +# RDEPENDS we define for it in this recipe, and thereby ensure that when
> +# adding the console-kit module to an image, we also get the necessary
> +# consolekit package produced.
>  PACKAGES =+ "libpulsecore libpulsecommon libpulse libpulse-simple libpulse-mainloop-glib \
> -             pulseaudio-server pulseaudio-misc"
> +             pulseaudio-server pulseaudio-misc pulseaudio-module-console-kit"

Can we add PACKAGECONFIG for this and add it to PACKAGES only
conditionally?

It causes hard dependency on consolekit -> libx11 so pulseaudio now
cannot be built for distros without x11 DISTRO_FEATURE.

>  #upgrade path:
>  RREPLACES_pulseaudio-server = "libpulse-bin libpulse-conf"
> -- 
> 1.8.3.4
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  reply	other threads:[~2013-12-11 21:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 18:07 Random fixes from the Mentor Graphics push queue Christopher Larson
2013-11-27 18:07 ` [PATCH 1/7] update-rc.d: process symlinks recursively Christopher Larson
2013-11-27 18:07 ` [PATCH 2/7] quota: apply patch to obey tcp-wrappers config Christopher Larson
2013-11-27 18:07 ` [PATCH 3/7] python, python-native: fix PARALLEL_MAKEINST failure Christopher Larson
2013-11-27 18:07 ` [PATCH 4/7] cairo: add/use packageconfig for valgrind support Christopher Larson
2013-11-27 18:07 ` [PATCH 5/7] perf: remove /usr/local/include from default makefile includes Christopher Larson
2013-11-27 18:07 ` [PATCH 6/7] qemu: handle CLOEXEC/NONBLOCK if unavailable on host Christopher Larson
2013-11-27 18:07 ` [PATCH 7/7] pulseaudio: fix RDEPENDS traversal for consolekit Christopher Larson
2013-12-11 21:22   ` Martin Jansa [this message]
2013-12-12 22:55     ` Chris Larson
2013-12-03 18:40 ` Random fixes from the Mentor Graphics push queue Chris Larson
2013-12-03 22:40   ` Richard Purdie
2013-12-04  2:38     ` Bruce Ashfield
2013-12-04  2:42       ` Chris Larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131211212254.GA3717@jama \
    --to=martin.jansa@gmail.com \
    --cc=chris_larson@mentor.com \
    --cc=kergoth@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox