From: Martin Jansa <martin.jansa@gmail.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] scripts/contrib: Add graph-tool
Date: Tue, 17 Dec 2013 18:16:35 +0100 [thread overview]
Message-ID: <20131217171635.GH3706@jama> (raw)
In-Reply-To: <c98716e9ead1e1273ed03a9bc812d792ea38dc5b.1387292119.git.paul.eggleton@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 4877 bytes --]
On Tue, Dec 17, 2013 at 02:56:21PM +0000, Paul Eggleton wrote:
> A simple script I put together for getting the paths from one node to
> another in a dot graph. This is useful for example in working out why
> a particular recipe is getting built in conjunction with dot graph files
> produced by bitbake -g.
>
> For example:
>
> $ bitbake -g core-image-minimal
> ...
> $ graph-tool find-paths pn-depends.dot core-image-minimal sqlite3-native
> core-image-minimal -> packagegroup-core-boot -> udev -> libxslt-native -> libxml2-native -> python-native -> sqlite3-native
Nice addition, thanks.
Can it show multiple paths? Maybe it would be better example to show it
on multiple-path case.
As future improvement it would be nice to be able to filter some paths,
e.g. sometimes I'm interested in runtime-dependencies, sometimes finding
path through runtime isn't enough (e.g. when my recipe has runtime
dependency of "foo" but actually needs "foo" at build time).
> Partially addresses [YOCTO #3362].
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
> scripts/contrib/graph-tool | 92 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 92 insertions(+)
> create mode 100755 scripts/contrib/graph-tool
>
> diff --git a/scripts/contrib/graph-tool b/scripts/contrib/graph-tool
> new file mode 100755
> index 0000000..6dc7d33
> --- /dev/null
> +++ b/scripts/contrib/graph-tool
> @@ -0,0 +1,92 @@
> +#!/usr/bin/env python
> +
> +# Simple graph query utility
> +# useful for getting answers from .dot files produced by bitbake -g
> +#
> +# Written by: Paul Eggleton <paul.eggleton@linux.intel.com>
> +#
> +# Copyright 2013 Intel Corporation
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License version 2 as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License along
> +# with this program; if not, write to the Free Software Foundation, Inc.,
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> +#
> +
> +import sys
> +
> +def get_path_networkx(dotfile, fromnode, tonode):
> + try:
> + import networkx
> + except ImportError:
> + print('ERROR: Please install the networkx python module')
> + sys.exit(1)
> +
> + graph = networkx.DiGraph(networkx.read_dot(dotfile))
> +
> + def node_missing(node):
> + import difflib
> + close_matches = difflib.get_close_matches(node, graph.nodes(), cutoff=0.7)
> + if close_matches:
> + print('ERROR: no node "%s" in graph. Close matches:\n %s' % (node, '\n '.join(close_matches)))
> + sys.exit(1)
> +
> + if not fromnode in graph:
> + node_missing(fromnode)
> + if not tonode in graph:
> + node_missing(tonode)
> + return networkx.all_simple_paths(graph, source=fromnode, target=tonode)
> +
> +
> +def find_paths(args, usage):
> + if len(args) < 3:
> + usage()
> + sys.exit(1)
> +
> + fromnode = args[1]
> + tonode = args[2]
> + paths = list(get_path_networkx(args[0], fromnode, tonode))
> + if paths:
> + for path in paths:
> + print ' -> '.join(path)
> + else:
> + print("ERROR: no path from %s to %s in graph" % (fromnode, tonode))
> + sys.exit(1)
> +
> +def main():
> + import optparse
> + parser = optparse.OptionParser(
> + usage = '''%prog [options] <command> <arguments>
> +
> +Available commands:
> + find-paths <dotfile> <from> <to>
> + Find all of the paths between two nodes in a dot graph''')
> +
> + #parser.add_option("-d", "--debug",
> + # help = "Report all SRCREV values, not just ones where AUTOREV has been used",
> + # action="store_true", dest="debug", default=False)
> +
> + options, args = parser.parse_args(sys.argv)
> + args = args[1:]
> +
> + if len(args) < 1:
> + parser.print_help()
> + sys.exit(1)
> +
> + if args[0] == "find-paths":
> + find_paths(args[1:], parser.print_help)
> + else:
> + parser.print_help()
> + sys.exit(1)
> +
> +
> +if __name__ == "__main__":
> + main()
> --
> 1.8.1.2
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-12-17 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 14:56 [PATCH 0/1] Add contrib script to find dependency chains Paul Eggleton
2013-12-17 14:56 ` [PATCH 1/1] scripts/contrib: Add graph-tool Paul Eggleton
2013-12-17 17:16 ` Martin Jansa [this message]
2013-12-17 17:30 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217171635.GH3706@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox