From: Martin Jansa <martin.jansa@gmail.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/4] openssl: use PACKAGECONFIG to disable perl bits
Date: Fri, 20 Dec 2013 10:36:45 +0100 [thread overview]
Message-ID: <20131220093645.GR3706@jama> (raw)
In-Reply-To: <1387521668-26329-4-git-send-email-sgw@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2499 bytes --]
On Thu, Dec 19, 2013 at 10:41:07PM -0800, Saul Wold wrote:
> Adding perl to the RDEPENDS caused a performance hit to the overall build time since this was
> the only package that depended on perl. The openssl-misc package is not installed by default
> so use a PACKAGECONFIG which can be overridden to allow the perl scripts along with perl to
> be installed.
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> meta/recipes-connectivity/openssl/openssl.inc | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-connectivity/openssl/openssl.inc b/meta/recipes-connectivity/openssl/openssl.inc
> index cdb1809..c58c99f 100644
> --- a/meta/recipes-connectivity/openssl/openssl.inc
> +++ b/meta/recipes-connectivity/openssl/openssl.inc
> @@ -13,8 +13,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=f9a8f968107345e0b75aa8c2ecaa7ec8"
>
> DEPENDS = "perl-native-runtime"
>
> -# Adding RDEPENDS for perl scripts
> -RDEPENDS_${PN}-misc +="perl"
> +PACKAGECONFIG[perl] = ",,,perl"
Doesn't it add perl to ${PN} (instead of ${PN}-misc)?
> SRC_URI = "http://www.openssl.org/source/openssl-${PV}.tar.gz \
> "
> @@ -157,11 +156,18 @@ do_install () {
>
> install -d ${D}${includedir}
> cp --dereference -R include/openssl ${D}${includedir}
> - sed -i -e '1s,.*,#!${bindir}/env perl,' ${D}${libdir}/ssl/misc/CA.pl
>
> oe_multilib_header openssl/opensslconf.h
> - # The c_rehash utility isn't installed by the normal installation process.
> - install -m 0755 ${S}/tools/c_rehash ${D}${bindir}
> + if [ "${@base_contains('PACKAGECONFIG', 'perl', 'perl', '', d)}" = "perl" ]; then
> + install -m 0755 ${S}/tools/c_rehash ${D}${bindir}
> + sed -i -e '1s,.*,#!${bindir}/env perl,' ${D}${bindir}/c_rehash
> + sed -i -e '1s,.*,#!${bindir}/env perl,' ${D}${libdir}/ssl/misc/CA.pl
> + sed -i -e '1s,.*,#!${bindir}/env perl,' ${D}${libdir}/ssl/misc/tsget
> + # The c_rehash utility isn't installed by the normal installation process.
> + else
> + rm -f ${D}${bindir}/c_rehash
> + rm -f ${D}${libdir}/ssl/misc/CA.pl ${D}${libdir}/ssl/misc/tsget
> + fi
> }
>
> BBCLASSEXTEND = "native nativesdk"
> --
> 1.8.3.1
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-12-20 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 6:41 [PATCH 0/4] Misc Fixes Saul Wold
2013-12-20 6:41 ` [PATCH 1/4] harfbuzz: Allow PACKAGECONFIG to be overridden Saul Wold
2013-12-20 6:41 ` [PATCH 2/4] beecrypt: " Saul Wold
2013-12-20 6:41 ` [PATCH 3/4] openssl: use PACKAGECONFIG to disable perl bits Saul Wold
2013-12-20 9:36 ` Martin Jansa [this message]
2013-12-20 6:41 ` [PATCH 4/4] util-linux: remove non PN based -dev packages Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220093645.GR3706@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox