Re: [PATCH 0/5] refactor the archive*.bbcalss

From: Martin Jansa <martin.jansa@gmail.com>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 0/5] refactor the archive*.bbcalss
Date: Thu, 16 Jan 2014 10:25:56 +0100	[thread overview]
Message-ID: <20140116092556.GD3742@jama> (raw)
In-Reply-To: <52D74086.4030602@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 3056 bytes --]

On Thu, Jan 16, 2014 at 10:14:30AM +0800, Robert Yang wrote:
> 
> 
> On 01/16/2014 12:55 AM, Martin Jansa wrote:
> > On Tue, Jan 14, 2014 at 12:20:14AM +0800, Robert Yang wrote:
> >> * The archive*.bbclass didn't work, and there were a few problems, for
> >>    example:
> >>    1) There were a few duplicated code
> >>    2) There was no src_dir.org (or orig), but the diff command still use
> >>       it, and it is not easy to fix this issue if we don't change a lot
> >>       of the code.
> >>    3) It didn't archive the source for the native or gcc
> >>    4) The work flow is not very well
> >>    5) The "subprocess.call('fakeroot cp xxxx'" should be removed
> >>    6) And others ...
> >>
> >> * So that we have to refactor it, the benefits are:
> >>    1) Fix the problems and make it work well.
> >>    2) Reduce more than 400 lines in total.
> >>    3) Make it easy to use.
> >>
> >> // Robert
> >>
> >> The following changes since commit 1b636173ca88e5ccca1992f9a12367a1189fa674:
> >>
> >>    bitbake: toaster: Toaster GUI, generic search, filter and order (2014-01-10 15:20:26 +0000)
> >>
> >> are available in the git repository at:
> >>
> >>    git://git.pokylinux.org/poky-contrib rbt/archiver
> >>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=rbt/archiver
> >
> > Can you send pull-request for oe-core?
> >
> 
> Here it is:
> git://git.pokylinux.org/poky-contrib rbt/ar_oe
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=rbt/ar_oe

This still looks like poky-contrib (so it will download whole
poky-contrib when I add it as remote to oe-core repo).

> // Robert
> 
> >> Robert Yang (5):
> >>    classes/archive*.bbclass: remove archive-*-source.bbclass
> >>    archiver.bbclass: refactor it
> >>    package_rpm.bbclass: archive the source to srpm package
> >>    archiver.bbclass: move a few code to copyleft_compliance.bbclass
> >>    local.conf.sample.extended: update for the archiver
> >>
> >>   meta-yocto/conf/local.conf.sample.extended     |  72 +--
> >>   meta/classes/archive-configured-source.bbclass |  65 ---
> >>   meta/classes/archive-original-source.bbclass   |  65 ---
> >>   meta/classes/archive-patched-source.bbclass    |  65 ---
> >>   meta/classes/archiver.bbclass                  | 723 ++++++++-----------------
> >>   meta/classes/copyleft_compliance.bbclass       |  55 +-
> >>   meta/classes/package_rpm.bbclass               |  31 +-
> >>   7 files changed, 316 insertions(+), 760 deletions(-)
> >>   delete mode 100644 meta/classes/archive-configured-source.bbclass
> >>   delete mode 100644 meta/classes/archive-original-source.bbclass
> >>   delete mode 100644 meta/classes/archive-patched-source.bbclass
> >>
> >> --
> >> 1.8.3.1
> >>
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]