From: Martin Jansa <martin.jansa@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] libtool-cross/native: Force usage of bash due to sstate inconsistencies
Date: Thu, 23 Jan 2014 13:48:33 +0100 [thread overview]
Message-ID: <20140123124833.GE3704@jama> (raw)
In-Reply-To: <1390479566.17424.99.camel@ted>
[-- Attachment #1: Type: text/plain, Size: 2039 bytes --]
On Thu, Jan 23, 2014 at 12:19:26PM +0000, Richard Purdie wrote:
> Scenario:
> a) libtool script is built on system with bash as /bin/sh
> b) machine B installs sstate from build a)
> c) machine B has dash as /bin/sh
>
> In this scenario, the script fails to work properly since its expecting
> /bin/sh to have bash like syntax and it no longer does have it.
>
> This patch forces the configure process to use /bin/bash, not /bin/sh
> and hence allows the scripts to work correctly when used from sstate.
Shouldn't oe-core commit 367a19aaf31bcf997f10d045e7954cc800189052 fix
that already? I don't see this issue on our builders since
367a19aaf31bcf997f10d045e7954cc800189052 was merged.
> (From OE-Core rev: 2c66aa0fc98b092ebb37baee94e92d1965afd76b)
This is sent from poky repo, right?
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb b/meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb
> index 34aae0b..72fad37 100644
> --- a/meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb
> +++ b/meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb
> @@ -39,3 +39,5 @@ libtoolcross_sysroot_preprocess () {
> }
>
> SSTATE_SCAN_FILES += "libtoolize *-libtool"
> +
> +export CONFIG_SHELL="/bin/bash"
> diff --git a/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb b/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb
> index df73f08..f1051d8 100644
> --- a/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb
> +++ b/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb
> @@ -22,3 +22,4 @@ do_install () {
> install -m 0755 ${HOST_SYS}-libtool ${D}${bindir}/${HOST_SYS}-libtool
> }
>
> +export CONFIG_SHELL="/bin/bash"
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
prev parent reply other threads:[~2014-01-23 12:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 12:19 [PATCH] libtool-cross/native: Force usage of bash due to sstate inconsistencies Richard Purdie
2014-01-23 12:37 ` Otavio Salvador
2014-01-23 12:42 ` Robert Yang
2014-01-23 12:44 ` Otavio Salvador
2014-01-23 12:48 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123124833.GE3704@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox