From: Mike Crowe <mac@mcrowe.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] curl: upgrade to 7.35.0
Date: Tue, 25 Feb 2014 11:03:55 +0000 [thread overview]
Message-ID: <20140225110355.GA32190@mcrowe.com> (raw)
In-Reply-To: <1393315179.31769.22.camel@ted>
On Tuesday 25 February 2014 at 07:59:39 +0000, Richard Purdie wrote:
> On Mon, 2014-02-24 at 21:33 -0800, Khem Raj wrote:
> > On Sun, Feb 23, 2014 at 2:20 PM, Mike Crowe <mac@mcrowe.com> wrote:
> > > Signed-off-by: Mike Crowe <mac@mcrowe.com>
> > > ---
> > > meta/recipes-support/curl/curl_7.34.0.bb | 63 ------------------------------
> > > meta/recipes-support/curl/curl_7.35.0.bb | 61 +++++++++++++++++++++++++++++
> >
> > can you generate patches with git format-patch -M ? makes renames
> > detection better
> > and patches are simple to review
>
> Cristiana sent out a patch for the same upgrade about the same time and
> I have to admit I took the other one since it was generated with -M and
> I could review it more easily...
It looks like you were wise to do so. Using format-patch -M on my commit
showed that I'd based mine on an old version of curl_7.34.0.bb.
Thanks, Khem, for the -M advice; I shall add it it to my checklist.
Mike.
prev parent reply other threads:[~2014-02-25 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 22:20 [PATCH] curl: upgrade to 7.35.0 Mike Crowe
2014-02-25 5:33 ` Khem Raj
2014-02-25 7:59 ` Richard Purdie
2014-02-25 11:03 ` Mike Crowe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225110355.GA32190@mcrowe.com \
--to=mac@mcrowe.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox