Re: [PATCH] pango: Fix postinst

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1929 bytes --]

On Thu, Feb 27, 2014 at 10:17:53PM +0000, Richard Purdie wrote:
> On Thu, 2014-02-27 at 23:15 +0100, Martin Jansa wrote:
> > On Thu, Feb 27, 2014 at 09:20:38PM +0100, Martin Jansa wrote:
> > > * do_split_packages was appending call to
> > >   ${bindir}/${MLPREFIX}pango-querymodules
> > >   without $D prefix or test if $D is empty, so it was always
> > >   failing on buildhostis without pango-querymodules and such
> > >   failure is fatal when rootfs is read-only (do_rootfs fails
> > >   because some packages weren't configured)
> > 
> > Something is wrong, in theory the
> > if [ "x$D" != "x" ]; then
> > case should always exit with 0 or 1 before it reaches the call added by
> > do_split_packages so it has to be qemu_run_binary call failing and
> > causing exit 1
> 
> Saul's error shows the shell parser in bitbake exiting. The function in
> question isn't getting run, its never getting past the parsing stage. As
> Saul mentions, it appears the if/fi balance isn't correct which would
> upset the shell parser...

Saul is correct, this version was wrong.. I had fixed version locally,
but than I've noticed that the exit calls should prevent the added
pango-querymodules call to be executed in do_rootfs, so I have started
checking what could be wrong and forgot to update status of this patch
on e-mail (or send v2 with fixed parsing) now I'm testing if the failure
is just because of missing qemu-native dependency.

meta/classes/qemu.bbclass doesn't add the dependency on qemu-native and
in image without any package which would be built with
  meta/classes/fontcache.bbclass:DEPENDS += "qemu-native"
  meta/classes/pixbufcache.bbclass:DEPENDS += "qemu-native"
it's IMHO still possible to end with do_rootfs being executed without
qemu-native being pulled into the build.

So v2 will came later after more testing.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]