From: Martin Jansa <martin.jansa@gmail.com>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/4] gummiboot: add COMPATIBLE_HOST
Date: Thu, 27 Mar 2014 12:39:49 +0100 [thread overview]
Message-ID: <20140327113949.GQ3709@jama> (raw)
In-Reply-To: <9bd12f5fca3736b2975ce0249b3428b5b0af194e.1395906475.git.liezhi.yang@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]
On Thu, Mar 27, 2014 at 04:11:22AM -0400, Robert Yang wrote:
> The gummiboot depends on gnu-efi which had set:
>
> COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"
>
> We also need set this for gummiboot, otherwise there would be build
> failures for other non-x86 archs.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> meta/recipes-bsp/gummiboot/gummiboot_git.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-bsp/gummiboot/gummiboot_git.bb b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
> index 5868a23..61de58c 100644
> --- a/meta/recipes-bsp/gummiboot/gummiboot_git.bb
> +++ b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
> @@ -13,6 +13,8 @@ PV = "43+git${SRCPV}"
> SRCREV = "4062c51075ba054d4949c714fe06123f9ad3097d"
> SRC_URI = "git://anongit.freedesktop.org/gummiboot"
>
It would be good to add comment here saying it's only because of gnu-efi
dependency (if gummiboot itself can in theory work on other hosts).
People won't notice it in commit message when they are looking at
recipe.
> +COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"
> +
> S = "${WORKDIR}/git"
>
> EXTRA_OECONF = "--disable-manpages --with-efi-includedir=${STAGING_INCDIR} \
> --
> 1.7.10.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2014-03-27 11:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 8:11 [PATCH 0/4] fixes for gummiboot and gnu-efi Robert Yang
2014-03-27 8:11 ` [PATCH 1/4] gnu-efi: fix the LIBDIR Robert Yang
2014-03-27 8:11 ` [PATCH 2/4] gummiboot: add COMPATIBLE_HOST Robert Yang
2014-03-27 11:39 ` Martin Jansa [this message]
2014-03-27 14:48 ` Robert Yang
2014-03-27 14:54 ` Robert Yang
2014-03-27 16:08 ` Khem Raj
2014-03-27 20:45 ` Fathi Boudra
2014-03-27 8:11 ` [PATCH 3/4] gummiboot: use objcopy from the env Robert Yang
2014-03-28 0:49 ` Khem Raj
2014-03-28 3:02 ` Robert Yang
2014-03-27 8:11 ` [PATCH 4/4] gummiboot: fix the installed but not shipped warning Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140327113949.GQ3709@jama \
--to=martin.jansa@gmail.com \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox