From: Denys Dmytriyenko <denis@denix.org>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: OpenEmbedded Core Mailing List
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] alsa-tools: Enable GTK support for X11 and Wayland
Date: Tue, 01 Apr 2014 14:50:00 -0400 [thread overview]
Message-ID: <20140401185000.GA3370@denix.org> (raw)
In-Reply-To: <1396372080-27607-2-git-send-email-otavio@ossystems.com.br>
On Tue, Apr 01, 2014 at 02:08:00PM -0300, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> This patch depends on the alsa-tools one I sent some minutes ago
>
> meta/recipes-multimedia/alsa/alsa-tools_1.0.27.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-multimedia/alsa/alsa-tools_1.0.27.bb b/meta/recipes-multimedia/alsa/alsa-tools_1.0.27.bb
> index 4f64a38..fdbe82a 100644
> --- a/meta/recipes-multimedia/alsa/alsa-tools_1.0.27.bb
> +++ b/meta/recipes-multimedia/alsa/alsa-tools_1.0.27.bb
> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://hdsploader/COPYING;md5=94d55d512a9ba36caa9b7df079bae1
> SRC_URI = "ftp://ftp.alsa-project.org/pub/tools/alsa-tools-${PV}.tar.bz2 \
> file://mips_has_no_io_h.patch \
> file://autotools.patch \
> - ${@base_contains('DISTRO_FEATURES', 'x11', '', 'file://makefile_no_gtk.patch', d)}"
> + ${@base_any_contains('DISTRO_FEATURES', 'x11', '', 'file://makefile_no_gtk.patch', d)}"
What's the reason to use any_contains here?
> SRC_URI[md5sum] = "1ea381d00a6069a98613aa7effa4cb51"
> SRC_URI[sha256sum] = "6562611b5a6560712f109e09740a9d4fa47296b07ed9590cb44139c5f154ada2"
> @@ -20,7 +20,7 @@ inherit autotools-brokensep
>
> EXTRA_OEMAKE += "GITCOMPILE_ARGS='--host=${HOST_SYS} --build=${BUILD_SYS} --target=${TARGET_SYS} --with-libtool-sysroot=${STAGING_DIR_HOST} --prefix=${prefix}'"
>
> -PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'x11', 'gtk+', '', d)}"
> +PACKAGECONFIG ??= "${@base_any_contains('DISTRO_FEATURES', 'x11', 'gtk+', '', d)}"
Same here - what's the reason for the change?
> PACKAGECONFIG[gtk+] = ",,gtk+ gtk+3,"
>
> # configure.ac/.in doesn't exist so force copy
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2014-04-01 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 17:07 [PATCH 1/2] oe.utils, utils.bbclass: Add any_contains and base_any_contains Otavio Salvador
2014-04-01 17:08 ` [PATCH 2/2] alsa-tools: Enable GTK support for X11 and Wayland Otavio Salvador
2014-04-01 18:50 ` Denys Dmytriyenko [this message]
2014-04-01 18:58 ` Otavio Salvador
2014-04-01 17:53 ` [PATCH 1/2] oe.utils, utils.bbclass: Add any_contains and base_any_contains Richard Purdie
2014-04-01 18:38 ` Otavio Salvador
2014-04-01 19:07 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401185000.GA3370@denix.org \
--to=denis@denix.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox