From: Martin Jansa <martin.jansa@gmail.com>
To: "Petter Mabäcker" <petter@technux.se>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 10/13] python: remove usage of FILESPATH
Date: Thu, 8 May 2014 12:53:34 +0200 [thread overview]
Message-ID: <20140508105334.GP30955@jama> (raw)
In-Reply-To: <f81a9671ffe21ca44d9a06d78a61550e94ba170c.1399497346.git.petter@technux.se>
[-- Attachment #1: Type: text/plain, Size: 2245 bytes --]
On Wed, May 07, 2014 at 11:19:56PM +0200, Petter Mabäcker wrote:
> Fixes [YOCTO #4497]
>
> Usage of FILESPATH is discouraged, since it can make recipes harder to
> bbappend. Instead FILESEXTRAPATHS should be used to extend the
> path. Don't migrate paths that already exist in base FILESPATH to
> FILESEXTRAPATHS (e.g. BPN, BP and files).
>
> Signed-off-by: Petter Mabäcker <petter@technux.se>
> ---
> .../recipes-devtools/python/python-native_2.7.3.bb | 2 +-
> .../python/python-pygobject_2.28.3.bb | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/python/python-native_2.7.3.bb b/meta/recipes-devtools/python/python-native_2.7.3.bb
> index 0c66d27..4949546 100644
> --- a/meta/recipes-devtools/python/python-native_2.7.3.bb
> +++ b/meta/recipes-devtools/python/python-native_2.7.3.bb
> @@ -21,7 +21,7 @@ SRC_URI += "\
> "
> S = "${WORKDIR}/Python-${PV}"
>
> -FILESPATH = "${FILE_DIRNAME}/python-native/:${FILE_DIRNAME}/python/"
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> inherit native
>
> diff --git a/meta/recipes-devtools/python/python-pygobject_2.28.3.bb b/meta/recipes-devtools/python/python-pygobject_2.28.3.bb
> index 9dbe47c..691666c 100644
> --- a/meta/recipes-devtools/python/python-pygobject_2.28.3.bb
> +++ b/meta/recipes-devtools/python/python-pygobject_2.28.3.bb
> @@ -16,7 +16,7 @@ SRC_URI[md5sum] = "aa64900b274c4661a5c32e52922977f9"
> SRC_URI[sha256sum] = "7da88c169a56efccc516cebd9237da3fe518a343095a664607b368fe21df95b6"
> S = "${WORKDIR}/pygobject-${PV}"
>
> -FILESPATH = "${FILE_DIRNAME}/python-pygobject:${FILE_DIRNAME}/files"
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
Is this one correct?
There is
BBCLASSEXTEND = "native"
and prepending python-pygobject-native doesn't seem to be needed.
> EXTRA_OECONF += "--disable-introspection"
>
> PARALLEL_MAKEINST = ""
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2014-05-08 10:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 21:19 [PATCH 00/13] Remove usage of FILESPATH Petter Mabäcker
2014-05-07 21:19 ` [PATCH 01/13] systemtap: remove " Petter Mabäcker
2014-05-07 21:19 ` [PATCH 02/13] dbus: " Petter Mabäcker
2014-05-07 21:19 ` [PATCH 03/13] gstreamer: remove unused FILESPATH Petter Mabäcker
2014-05-07 21:19 ` [PATCH 04/13] trace-cmd: remove usage of FILESPATH Petter Mabäcker
2014-05-08 10:46 ` Martin Jansa
2014-05-08 14:56 ` petter
2014-05-07 21:19 ` [PATCH 05/13] xorg-lib: " Petter Mabäcker
2014-05-07 21:19 ` [PATCH 06/13] mesa: " Petter Mabäcker
2014-05-08 10:49 ` Martin Jansa
2014-05-09 5:11 ` petter
2014-05-07 21:19 ` [PATCH 07/13] qemu: remove unused FILESPATH Petter Mabäcker
2014-05-07 21:19 ` [PATCH 08/13] linuxdoc-tools: remove usage of FILESPATH Petter Mabäcker
2014-05-08 10:50 ` Martin Jansa
2014-05-08 14:48 ` petter
2014-05-07 21:19 ` [PATCH 09/13] gcc: " Petter Mabäcker
2014-05-07 21:19 ` [PATCH 10/13] python: " Petter Mabäcker
2014-05-08 10:53 ` Martin Jansa [this message]
2014-05-09 4:53 ` petter
2014-05-07 21:19 ` [PATCH 11/13] u-boot: remove unused FILESPATH Petter Mabäcker
2014-05-07 21:19 ` [PATCH 12/13] uclibc: remove usage of FILESPATH Petter Mabäcker
2014-05-07 21:19 ` [PATCH 13/13] eglibc: " Petter Mabäcker
2014-05-07 22:21 ` [PATCH 00/13] Remove " Richard Purdie
2014-05-08 4:37 ` petter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508105334.GP30955@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=petter@technux.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox