Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Anders Darander <anders@chargestorm.se>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] oeqa/controllers/beaglebonetarget.py: fix conditions for files copied to /boot
Date: Tue, 27 May 2014 11:51:03 +0200	[thread overview]
Message-ID: <20140527095102.GF7185@ad.chargestorm.se> (raw)
In-Reply-To: <1401184227-1138-1-git-send-email-corneliux.stoicescu@intel.com>

Just nitpicking a little...

It should ideally have had a [PATCH v2] header, to make it easier to see
that it's an updated patch.

If Saul or someone else picks this up, there should be no need to
resubmit. But anyway, for the next time.

* Corneliu Stoicescu <corneliux.stoicescu@intel.com> [140527 09:46]:
> Using '&&' as condition operator in '[ ! -e /mnt/testrootfs/boot/uImage ] && cp ~/test-kernel /mnt/testrootfs/boot/uImage' would result in exit code 1 if the first condition is not met.
> Changing the code to handle the conditioning more cleanly and correctly return exit status 0 if [ ! -e /mnt/testrootfs/boot/uImage ] returns exit code 1.

Preferably, the commit message should be line wrapped at ~78 chars.

> Without this if the file existance check would fail then the image deploy task would stop.

> Signed-off-by: Corneliu Stoicescu <corneliux.stoicescu@intel.com>
> ---

A short changelog between version should go here. (In this case just
stating that the commit message was improved).

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB / eStorm AB


  reply	other threads:[~2014-05-27  9:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27  9:50 [PATCH] oeqa/controllers/beaglebonetarget.py: fix conditions for files copied to /boot Corneliu Stoicescu
2014-05-27  9:51 ` Anders Darander [this message]
2014-05-27 11:14 ` Stefan Stanacar
2014-05-27 14:24   ` Saul Wold
2014-05-27 15:12     ` Stoicescu, CorneliuX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140527095102.GF7185@ad.chargestorm.se \
    --to=anders@chargestorm.se \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox