From: Laurentiu Palcu <laurentiu.palcu@intel.com>
To: Dennis Meier <meier.dennis@siemens.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] populate_sdk_base: add auto-completion in setup
Date: Tue, 17 Jun 2014 17:03:48 +0300 [thread overview]
Message-ID: <20140617140348.GD26745@lpalcu-linux> (raw)
In-Reply-To: <1403011013-29977-1-git-send-email-meier.dennis@siemens.com>
On Tue, Jun 17, 2014 at 03:16:53PM +0200, Dennis Meier wrote:
> Signed-off-by: Dennis Meier <meier.dennis@siemens.com>
> ---
> meta/classes/populate_sdk_base.bbclass | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> index 35d837d..1182425 100644
> --- a/meta/classes/populate_sdk_base.bbclass
> +++ b/meta/classes/populate_sdk_base.bbclass
> @@ -173,9 +173,8 @@ if [ $verbose = 1 ] ; then
> set -x
> fi
>
> -printf "Enter target directory for SDK (default: $DEFAULT_INSTALL_DIR): "
> if [ "$target_sdk_dir" = "" ]; then
> - read target_sdk_dir
> + read -e -p "Enter target directory for SDK (default: $DEFAULT_INSTALL_DIR): " target_sdk_dir
> [ "$target_sdk_dir" = "" ] && target_sdk_dir=$DEFAULT_INSTALL_DIR
> else
> echo "$target_sdk_dir"
Moving the above printf in the 'if' branch will make this 'echo' look
strange when the target directory is provided with the -d option... I
believe you can remove this 'echo' completely though. There is another
message, later, informing the user where the SDK gets installed.
laurentiu
> --
> 1.7.10.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2014-06-17 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 13:16 [PATCH] populate_sdk_base: add auto-completion in setup Dennis Meier
2014-06-17 14:03 ` Laurentiu Palcu [this message]
2014-06-29 8:01 ` Richard Purdie
2014-06-17 14:39 ` Otavio Salvador
2014-06-18 10:15 ` Richard Purdie
2014-06-18 11:29 ` Otavio Salvador
2014-06-24 10:01 ` Meier, Dennis
2014-06-25 16:26 ` Paul Eggleton
2014-06-25 16:58 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617140348.GD26745@lpalcu-linux \
--to=laurentiu.palcu@intel.com \
--cc=meier.dennis@siemens.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox