Re: [PATCH] u-boot-fw-utils: install config file

[Tom Rini <trini@ti.com>]

On Thu, Jun 26, 2014 at 03:34:07PM +0200, Maxin B. John wrote:
> Hi Tom,
> 
> On Thu, Jun 26, 2014 at 08:27:00AM -0400, Tom Rini wrote:
> > On Wed, Jun 25, 2014 at 11:13:59AM +0200, Maxin B. John wrote:
> > > From: "Maxin B. John" <maxin.john@enea.com>
> > > 
> <snip>
> > > +  install -m 0644 ${S}/tools/env/fw_env.config ${D}${sysconfdir}/fw_env.config
> > >  }
> > >  
> > >  PACKAGE_ARCH = "${MACHINE_ARCH}"
> > 
> > We should really provide some way for the BSP to provide a functional
> > fw_env.config file as the one in the sources is mainly an example and
> > unlikely to work on most systems.
> I do agree that it is just an example file. However, without the configuration 
> file, fw_printenv will fail with this warning:
> 
> #fw_printenv 
> Cannot parse config file: No such file or directory
> 
> IMHO, those who want to use a "real" config file, should use a proper ".bbappend"
> eg:
> 
> do_install_append() {
> 
> case "${MACHINE}" in "mymachine" )
>         echo ' myargs '> ${D}${sysconfdir}/fw_env.config;;
> *);;
> 
> esac
> }
> 
> Is this an acceptable way or should we modify it ?

Ah, OK, cobwebs dusted off.  The u-boot recipe currently provides
fw_env.config correct for the board in question, so long as it's
provided.

-- 
Tom