From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by mail.openembedded.org (Postfix) with ESMTP id 48ED47064B for ; Fri, 18 Jul 2014 14:15:50 +0000 (UTC) Received: by mail-wg0-f45.google.com with SMTP id x12so3623269wgg.16 for ; Fri, 18 Jul 2014 07:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=gcItjG8ZmIp7LRlmciAWWOaMqhRiTYQjBVg0Ae3FsVc=; b=odjFgGfwLK0QgKFhfsegzXe54NZb7oz8Zw9QTK7KYiHUwvBZFRlxJWk6rfUZyIPMY/ G2Ufs4+OhUSz/XKK45Da2gTVAHm+wqdXUOQ2bTKLbqU3doPJe/nybNJUAiTrwkozw/PG f70XxRPBKGIMQ6Zci3qq1JA/8qGLqx+l8XrN1iGLKkdafP4X3GECO4eQSMarrVuwiTMS i+2obldw8s4RmsSngnmAF+BCUV0NfIlVPkHgGr/JY2O5EHOgFaxdQUYoP8cIRfVpZRc1 +T5FmzrTkEVakHFrydt/NXSv+jXd23RjQUABGb8mKHZKjN4Ev0jI15X0I6f0wefT11bs UKEA== X-Received: by 10.194.200.37 with SMTP id jp5mr7061631wjc.120.1405692948960; Fri, 18 Jul 2014 07:15:48 -0700 (PDT) Received: from localhost (ip-89-176-104-3.net.upcbroadband.cz. [89.176.104.3]) by mx.google.com with ESMTPSA id 10sm14544688wjr.22.2014.07.18.07.15.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jul 2014 07:15:47 -0700 (PDT) From: Martin Jansa X-Google-Original-From: Martin Jansa Date: Fri, 18 Jul 2014 16:15:58 +0200 To: Richard Purdie Message-ID: <20140718141558.GP2433@jama> References: <1405638947-30399-1-git-send-email-Martin.Jansa@gmail.com> <1405689866.26348.39.camel@ted> MIME-Version: 1.0 In-Reply-To: <1405689866.26348.39.camel@ted> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Martin Jansa , openembedded-core@lists.openembedded.org Subject: Re: [PATCH] gcc-4.8: backport fix for ICE when building opus X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jul 2014 14:15:54 -0000 X-Groupsio-MsgNum: 55218 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BN1FuguMf1o6kBCi" Content-Disposition: inline --BN1FuguMf1o6kBCi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 18, 2014 at 02:24:26PM +0100, Richard Purdie wrote: > On Fri, 2014-07-18 at 01:15 +0200, Martin Jansa wrote: > > From: Martin Jansa > >=20 > > * backported from 4.8.2, so daisy isn't affected > >=20 > > Signed-off-by: Martin Jansa > > --- > > meta/recipes-devtools/gcc/gcc-4.8.inc | 1 + > > .../gcc-4.8/0001-fix-ICE-when-building-opus.patch | 121 +++++++++++++= ++++++++ > > 2 files changed, 122 insertions(+) > > create mode 100644 meta/recipes-devtools/gcc/gcc-4.8/0001-fix-ICE-when= -building-opus.patch >=20 > Doesn't apply against master? > > * backported from 4.8.2, so daisy isn't affected 4.8.2 and 4.9.0 in master also aren't affected :) > Cheers, >=20 > Richard >=20 > > diff --git a/meta/recipes-devtools/gcc/gcc-4.8.inc b/meta/recipes-devto= ols/gcc/gcc-4.8.inc > > index f1260af..ac205de 100644 > > --- a/meta/recipes-devtools/gcc/gcc-4.8.inc > > +++ b/meta/recipes-devtools/gcc/gcc-4.8.inc > > @@ -79,6 +79,7 @@ SRC_URI =3D "${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.ta= r.bz2 \ > > file://0047-repomembug.patch \ > > file://0048-PR57532.patch \ > > file://0048-PR58854_fix_arm_apcs_epilogue.patch \ > > + file://0001-fix-ICE-when-building-opus.patch \ > > " > > SRC_URI[md5sum] =3D "3b2386c114cd74185aa3754b58a79304" > > SRC_URI[sha256sum] =3D "545b44be3ad9f2c4e90e6880f5c9d4f0a8f0e5f67e1ffb= 0d45da9fa01bb05813" > > diff --git a/meta/recipes-devtools/gcc/gcc-4.8/0001-fix-ICE-when-buildi= ng-opus.patch b/meta/recipes-devtools/gcc/gcc-4.8/0001-fix-ICE-when-buildin= g-opus.patch > > new file mode 100644 > > index 0000000..9d3aeaa > > --- /dev/null > > +++ b/meta/recipes-devtools/gcc/gcc-4.8/0001-fix-ICE-when-building-opus= =2Epatch > > @@ -0,0 +1,121 @@ > > +From 22228d8ba86c70381f7c34c22ac6994234d0f3e7 Mon Sep 17 00:00:00 2001 > > +From: xguo > > +Date: Fri, 9 Aug 2013 06:59:01 +0000 > > +Subject: [PATCH] gcc/ChangeLog: > > + > > + Backport from mainline: > > + 2013-08-09 Zhenqiang Chen > > + > > + * config/arm/neon.md (vcond): Fix floating-point vector > > + comparisons against 0. > > + > > +gcc/testsuite/ChangeLog: > > + > > + Backport from mainline: > > + 2013-08-09 Zhenqiang Chen > > + > > + * gcc.target/arm/lp1189445.c: New testcase. > > + > > +Upstream-Status: Backport from 4.8.2 > > +Signed-off-by: Martin Jansa > > + > > +More details in: > > +http://gcc.1065356.n5.nabble.com/PATCH-ARM-Fix-unrecognizable-vector-c= omparisons-td947064.html > > + > > +git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gcc-4_8-branch@2016= 20 138bc75d-0d04-0410-961f-82ee72b054a4 > > +--- > > + gcc/ChangeLog | 8 ++++++++ > > + gcc/config/arm/neon.md | 34 +++++++++++++++++++++++= ++++----- > > + gcc/testsuite/ChangeLog | 7 +++++++ > > + gcc/testsuite/gcc.target/arm/lp1189445.c | 18 +++++++++++++++++ > > + 4 files changed, 62 insertions(+), 5 deletions(-) > > + create mode 100644 gcc/testsuite/gcc.target/arm/lp1189445.c > > + > > +diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md > > +index d8d4202..86a5932 100644 > > +--- a/gcc/config/arm/neon.md > > ++++ b/gcc/config/arm/neon.md > > +@@ -1732,6 +1732,7 @@ > > + ? 3 : 1; > > + rtx magic_rtx =3D GEN_INT (magic_word); > > + int inverse =3D 0; > > ++ int use_zero_form =3D 0; > > + int swap_bsl_operands =3D 0; > > + rtx mask =3D gen_reg_rtx (mode); > > + rtx tmp =3D gen_reg_rtx (mode); > > +@@ -1742,12 +1743,16 @@ > > + switch (GET_CODE (operands[3])) > > + { > > + case GE: > > ++ case GT: > > + case LE: > > ++ case LT: > > + case EQ: > > +- if (!REG_P (operands[5]) > > +- && (operands[5] !=3D CONST0_RTX (mode))) > > +- operands[5] =3D force_reg (mode, operands[5]); > > +- break; > > ++ if (operands[5] =3D=3D CONST0_RTX (mode)) > > ++ { > > ++ use_zero_form =3D 1; > > ++ break; > > ++ } > > ++ /* Fall through. */ > > + default: > > + if (!REG_P (operands[5])) > > + operands[5] =3D force_reg (mode, operands[5]); > > +@@ -1798,7 +1803,26 @@ > > + a GT b -> a GT b > > + a LE b -> b GE a > > + a LT b -> b GT a > > +- a EQ b -> a EQ b */ > > ++ a EQ b -> a EQ b > > ++ Note that there also exist direct comparison against 0 forms, > > ++ so catch those as a special case. */ > > ++ if (use_zero_form) > > ++ { > > ++ inverse =3D 0; > > ++ switch (GET_CODE (operands[3])) > > ++ { > > ++ case LT: > > ++ base_comparison =3D gen_neon_vclt; > > ++ break; > > ++ case LE: > > ++ base_comparison =3D gen_neon_vcle; > > ++ break; > > ++ default: > > ++ /* Do nothing, other zero form cases already have the correct > > ++ base_comparison. */ > > ++ break; > > ++ } > > ++ } > > +=20 > > + if (!inverse) > > + emit_insn (base_comparison (mask, operands[4], operands[5], magic_rt= x)); > > +diff --git a/gcc/testsuite/gcc.target/arm/lp1189445.c b/gcc/testsuite/= gcc.target/arm/lp1189445.c > > +new file mode 100644 > > +index 0000000..766748e > > +--- /dev/null > > ++++ b/gcc/testsuite/gcc.target/arm/lp1189445.c > > +@@ -0,0 +1,18 @@ > > ++/* { dg-do compile } */ > > ++/* { dg-require-effective-target arm_neon } */ > > ++/* { dg-add-options arm_neon } */ > > ++/* { dg-options "-O3" } */ > > ++ > > ++int id; > > ++int > > ++test (const long int *data) > > ++{ > > ++ int i, retval; > > ++ retval =3D id; > > ++ for (i =3D 0; i < id; i++) > > ++ { > > ++ retval &=3D (data[i] <=3D 0); > > ++ } > > ++ > > ++ return (retval); > > ++} > > +--=20 > > +2.0.0 > > + > > --=20 > > 1.9.1 > >=20 >=20 >=20 --=20 Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com --BN1FuguMf1o6kBCi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlPJLB4ACgkQN1Ujt2V2gByIzQCghSlcCTU2WTvy9c5Q3Ioaudqo lBYAn3FpTb6Oslr/WDxJJGgzCpJs4Q+8 =o3Ub -----END PGP SIGNATURE----- --BN1FuguMf1o6kBCi--