Re: [PATCH] python2: Add PACKAGECONFIG for tkinter to support tk from meta-oe

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]

On Sun, Jul 20, 2014 at 09:01:05PM -0400, Jate S wrote:
> The presence of the tk library determines whether python's compile
> task will build tkinter. Then the presence of python-tkinter in
> IMAGE_INSTALL will then determine whether it is installed.
> 
> In the absence of tk provided by meta-oe, the python recipe will
> install an empty python-tkinter package.
> 
> I cannot think of a cleaner way to do this right now. Ideally the
> package python-tkinter could trigger a python DEPENDS on tk...
> 
> 
> Martin, you originally suggested the PACKAGECONFIG. Do you have any
> further thoughts on this?

Richard just submitted patch to explicitly disable tk, extend the patch
to make it configurable and use this new option from PACKAGECONFIG

http://git.openembedded.org/openembedded-core/commit/?id=53ae544cfdac22c82af452b8c7ebe6664296bd9b

> 
> - Jate S.
> 
> 
> On Mon, Jul 14, 2014 at 2:32 PM, Enrico Scholz
> <enrico.scholz@sigma-chemnitz.de> wrote:
> > Jate S <jatedev@gmail.com> writes:
> >
> >> Python 2.7.x does not use an explicit configure option for tk support.
> >> Instead, it tries to detect the tk and tcl libraries before compiling
> >> python-tkinter.
> >
> > Your patch does not solve the issue of non-deterministic builds.  When
> > tk was added by some other way, python will get tkinter support although
> > PACKAGECONFIG was not set.
> >
> > An idea to make build deterministic might be patching of detect_modules()
> > in setup.py to add disabled modules to 'missing'.  E.g.
> >
> > |             missing.append('_tkinter')
> > |
> > |+        missing.extend(os.environ('OE_HACK_MISSING').split())
> > |         return missing
> >
> > Probably there are better/cleaner ways but I am not familar with python
> > distutils.
> >
> >
> > Enrico

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]