Re: [oe-commits] Cristian Iorga : qemu: fix qemu-native pkg-config paths

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2347 bytes --]

On Wed, Jul 30, 2014 at 02:28:28PM +0100, Richard Purdie wrote:
> On Wed, 2014-07-30 at 11:32 +0200, Martin Jansa wrote:
> > On Fri, Jul 18, 2014 at 10:50:12PM +0200, Martin Jansa wrote:
> > > On Thu, Jul 03, 2014 at 04:47:08PM +0000, git@git.openembedded.org wrote:
> > > > Module: openembedded-core.git
> > > > Branch: master
> > > > Commit: 68a5ed337f8f7ee8e5bf55542ec82d786eb754db
> > > > URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=68a5ed337f8f7ee8e5bf55542ec82d786eb754db
> > > > 
> > > > Author: Cristian Iorga <cristian.iorga@intel.com>
> > > > Date:   Thu Jul  3 15:57:32 2014 +0300
> > > > 
> > > > qemu: fix qemu-native pkg-config paths
> > > > 
> > > > For qemu-native, the pkg-config paths do not
> > > > include build host paths.
> > > 
> > > This breaks qemu-native builds on hosts without pkg-config.
> > > 
> > > pkg-config isn't in sanity.bbclass's SANITY_REQUIRED_UTILITIES
> > > and this is first recipe which cannot use pkgconfig-native.
> > > 
> > > Please add test that it exists before forcing recipe to use it.
> > 
> > PING
> > 
> > This is broken for almost a month, please at least revert it until it's
> > fixed correctly.
> 
> Well, if I revert this, I'd then need to revert other things and it
> turns into a dependency chain nightmare. So the reality is this needs to
> get fixed.
> 
> I'm assuming in your case, you probably either don't have or care about
> SDL at all, or you have sdl-config available?

Correct, it's just build server where I'll never use runqemu to run the
image, but I need to build usable qemu-native to generate read-only
images (e.g. for fontcache.bbclass).

> So what really needs to happen here is that running the command needs to
> become non-fatal as far as I can tell?

Yes, non-fatal and if possible deterministic (AFAIK this whole block could be
included in PACKAGECONFIG contains "sdl" conditional and applied only
when /bin/pkg-config or /usr/bin/pkg-config exists)

There was also request to provide libsdl-native
http://patchwork.openembedded.org/patch/63477/

then qemu-native could just build this libsdl-native as dependency for
PACKAGECONFIG sdl instead of assuming that the host system has
undeclared libsdl-native dependency. 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]