Re: [PATCH 0/5] Add initial fitImage support

[Marek Vasut <marex@denx.de>]

On Thursday, August 07, 2014 at 10:10:28 PM, Saul Wold wrote:
> On 08/07/2014 08:17 AM, Marek Vasut wrote:
> > The fitImage is a successor of the U-Boot uImage format, which is
> > considered legacy for years now. The fitImage allows packing multiple
> > kernel images, DTBs and other artifacts into a single image, which can
> > then be protected by SHA checksums and does even support signing the
> > images for verified boot.
> > 
> > This patchset is the first stab at adding the new image format into
> > Yocto.
> > 
> > Marek Vasut (5):
> >    Yocto: kernel: Rework do_uboot_mkimage
> >    Yocto: kernel: Pull out the linux.bin generation
> >    Yocto: kernel: Clean up KERNEL_IMAGETYPE_FOR_MAKE
> >    Yocto: kernel: Build DTBs early
> >    Yocto: kernel: Add basic fitImage support
> >   
> >   meta/classes/kernel.bbclass             | 229
> >   +++++++++++++++++++++++++++++---
> >   meta/recipes-kernel/linux/linux-dtb.inc |  14 +-
> >   2 files changed, 226 insertions(+), 17 deletions(-)
> 
> Hi Marek,
> 
> I am going to make a general request, can you please review the Commit
> Guildlines Wiki for Openembedded:
> 
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> 
> We appreciate your patches, but the commit messages need to be formatted
> correctly.  The Yocto: tag is not needed and you could clearly include
> which recipe, bbclass, file or subsystem (if across multiple files) so
> in the above it would be kernel.bbclass: ...
> 
> If you could please resubmit your changes with the correct commit
> summary for this series and your other patches that would be greatly
> appreciated.
> 
> Myself and others may have further feedback on your patches.

Ah, thanks! I'll give it a few days and will do V2 as per guidelines. Sorry for 
the mistake.

Best regards,
Marek Vasut