From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by mail.openembedded.org (Postfix) with ESMTP id D880365D5E for ; Mon, 11 Aug 2014 11:04:02 +0000 (UTC) Received: by mail-wi0-f177.google.com with SMTP id ho1so3975594wib.16 for ; Mon, 11 Aug 2014 04:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=V4TH7TNQS4GrPdUfL0u5Ctjabw6Bk+yfq34jNFe7mVQ=; b=YeWWASv5YZpWXN8LMzKZfN6gzQBf7O7tHM6Q3a2GO872/Xl/xH+DyjrtJjOqJJBg+h 3ma9zAwW96Mk88qxhp8UYnYdeGAv85QdWGUDf815kw3Kt/Jl/LdCHwi2Uepxtu/oR5wn +NA9bHYRRkorCv7RU4TsJOkTnOFMvv1mtcKq4sNAqIxBW7CK6WNUhX0F8ZgPN73lmXRg vaBcRqFAvQKSCfcQdh6deEC/jIWcY1HkXs0OqmK6pUCidI8jgi6ZzPYlmZOv8naTVk8a 5PvqT5d3iA7wBAfDMyozohUOJsthIRJ5G+i2wHr5X2KyfbifKmdqSBXMpM+ZK0oBh8fc Dxgw== X-Received: by 10.180.182.67 with SMTP id ec3mr24979628wic.21.1407755043349; Mon, 11 Aug 2014 04:04:03 -0700 (PDT) Received: from localhost (ip-89-176-104-3.net.upcbroadband.cz. [89.176.104.3]) by mx.google.com with ESMTPSA id u10sm42542859wix.14.2014.08.11.04.04.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Aug 2014 04:04:02 -0700 (PDT) From: Martin Jansa X-Google-Original-From: Martin Jansa Date: Mon, 11 Aug 2014 13:04:37 +0200 To: Robert Yang Message-ID: <20140811110437.GA14848@jama> References: <1405638999-9737-1-git-send-email-Martin.Jansa@gmail.com> <20140725001645.GQ2492@jama> <53D85A56.6060401@windriver.com> MIME-Version: 1.0 In-Reply-To: <53D85A56.6060401@windriver.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: openembedded-core@lists.openembedded.org Subject: Re: [dora][PATCHv2] gcc-4.8: backport fix for ICE when building opus X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Aug 2014 11:04:04 -0000 X-Groupsio-MsgNum: 56288 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="F02tnJshPGiBzxqM" Content-Disposition: inline --F02tnJshPGiBzxqM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 30, 2014 at 10:37:10AM +0800, Robert Yang wrote: >=20 > On 07/25/2014 08:16 AM, Martin Jansa wrote: > > On Fri, Jul 18, 2014 at 01:16:39AM +0200, Martin Jansa wrote: > >> From: Martin Jansa > >> > >> * backported from 4.8.2, so daisy isn't affected > > > > Robert, any eta on this one? If we cannot expect this to be merged in > > dora in next few days, let me know and I'll temporary add it to > > .bbappends in our layers. >=20 > Sorry for the late response, I tested it and worked well, I will confirm > with RP. There were some dora changes merged today, but this one wasn't one of them, is there some issue with it? > > Regards, > > > >> Signed-off-by: Martin Jansa > >> --- > >> meta/recipes-devtools/gcc/gcc-4.8.inc | 1 + > >> .../gcc-4.8/0001-fix-ICE-when-building-opus.patch | 121 +++++++++++= ++++++++++ > >> 2 files changed, 122 insertions(+) > >> create mode 100644 meta/recipes-devtools/gcc/gcc-4.8/0001-fix-ICE-wh= en-building-opus.patch > >> > >> diff --git a/meta/recipes-devtools/gcc/gcc-4.8.inc b/meta/recipes-devt= ools/gcc/gcc-4.8.inc > >> index f1260af..ac205de 100644 > >> --- a/meta/recipes-devtools/gcc/gcc-4.8.inc > >> +++ b/meta/recipes-devtools/gcc/gcc-4.8.inc > >> @@ -79,6 +79,7 @@ SRC_URI =3D "${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.t= ar.bz2 \ > >> file://0047-repomembug.patch \ > >> file://0048-PR57532.patch \ > >> file://0048-PR58854_fix_arm_apcs_epilogue.patch \ > >> + file://0001-fix-ICE-when-building-opus.patch \ > >> " > >> SRC_URI[md5sum] =3D "3b2386c114cd74185aa3754b58a79304" > >> SRC_URI[sha256sum] =3D "545b44be3ad9f2c4e90e6880f5c9d4f0a8f0e5f67e1f= fb0d45da9fa01bb05813" > >> diff --git a/meta/recipes-devtools/gcc/gcc-4.8/0001-fix-ICE-when-build= ing-opus.patch b/meta/recipes-devtools/gcc/gcc-4.8/0001-fix-ICE-when-buildi= ng-opus.patch > >> new file mode 100644 > >> index 0000000..9d3aeaa > >> --- /dev/null > >> +++ b/meta/recipes-devtools/gcc/gcc-4.8/0001-fix-ICE-when-building-opu= s.patch > >> @@ -0,0 +1,121 @@ > >> +From 22228d8ba86c70381f7c34c22ac6994234d0f3e7 Mon Sep 17 00:00:00 2001 > >> +From: xguo > >> +Date: Fri, 9 Aug 2013 06:59:01 +0000 > >> +Subject: [PATCH] gcc/ChangeLog: > >> + > >> + Backport from mainline: > >> + 2013-08-09 Zhenqiang Chen > >> + > >> + * config/arm/neon.md (vcond): Fix floating-point vector > >> + comparisons against 0. > >> + > >> +gcc/testsuite/ChangeLog: > >> + > >> + Backport from mainline: > >> + 2013-08-09 Zhenqiang Chen > >> + > >> + * gcc.target/arm/lp1189445.c: New testcase. > >> + > >> +Upstream-Status: Backport from 4.8.2 > >> +Signed-off-by: Martin Jansa > >> + > >> +More details in: > >> +http://gcc.1065356.n5.nabble.com/PATCH-ARM-Fix-unrecognizable-vector-= comparisons-td947064.html > >> + > >> +git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gcc-4_8-branch@201= 620 138bc75d-0d04-0410-961f-82ee72b054a4 > >> +--- > >> + gcc/ChangeLog | 8 ++++++++ > >> + gcc/config/arm/neon.md | 34 ++++++++++++++++++++++= +++++----- > >> + gcc/testsuite/ChangeLog | 7 +++++++ > >> + gcc/testsuite/gcc.target/arm/lp1189445.c | 18 +++++++++++++++++ > >> + 4 files changed, 62 insertions(+), 5 deletions(-) > >> + create mode 100644 gcc/testsuite/gcc.target/arm/lp1189445.c > >> + > >> +diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md > >> +index d8d4202..86a5932 100644 > >> +--- a/gcc/config/arm/neon.md > >> ++++ b/gcc/config/arm/neon.md > >> +@@ -1732,6 +1732,7 @@ > >> + ? 3 : 1; > >> + rtx magic_rtx =3D GEN_INT (magic_word); > >> + int inverse =3D 0; > >> ++ int use_zero_form =3D 0; > >> + int swap_bsl_operands =3D 0; > >> + rtx mask =3D gen_reg_rtx (mode); > >> + rtx tmp =3D gen_reg_rtx (mode); > >> +@@ -1742,12 +1743,16 @@ > >> + switch (GET_CODE (operands[3])) > >> + { > >> + case GE: > >> ++ case GT: > >> + case LE: > >> ++ case LT: > >> + case EQ: > >> +- if (!REG_P (operands[5]) > >> +- && (operands[5] !=3D CONST0_RTX (mode))) > >> +- operands[5] =3D force_reg (mode, operands[5]); > >> +- break; > >> ++ if (operands[5] =3D=3D CONST0_RTX (mode)) > >> ++ { > >> ++ use_zero_form =3D 1; > >> ++ break; > >> ++ } > >> ++ /* Fall through. */ > >> + default: > >> + if (!REG_P (operands[5])) > >> + operands[5] =3D force_reg (mode, operands[5]); > >> +@@ -1798,7 +1803,26 @@ > >> + a GT b -> a GT b > >> + a LE b -> b GE a > >> + a LT b -> b GT a > >> +- a EQ b -> a EQ b */ > >> ++ a EQ b -> a EQ b > >> ++ Note that there also exist direct comparison against 0 forms, > >> ++ so catch those as a special case. */ > >> ++ if (use_zero_form) > >> ++ { > >> ++ inverse =3D 0; > >> ++ switch (GET_CODE (operands[3])) > >> ++ { > >> ++ case LT: > >> ++ base_comparison =3D gen_neon_vclt; > >> ++ break; > >> ++ case LE: > >> ++ base_comparison =3D gen_neon_vcle; > >> ++ break; > >> ++ default: > >> ++ /* Do nothing, other zero form cases already have the correct > >> ++ base_comparison. */ > >> ++ break; > >> ++ } > >> ++ } > >> + > >> + if (!inverse) > >> + emit_insn (base_comparison (mask, operands[4], operands[5], magic_r= tx)); > >> +diff --git a/gcc/testsuite/gcc.target/arm/lp1189445.c b/gcc/testsuite= /gcc.target/arm/lp1189445.c > >> +new file mode 100644 > >> +index 0000000..766748e > >> +--- /dev/null > >> ++++ b/gcc/testsuite/gcc.target/arm/lp1189445.c > >> +@@ -0,0 +1,18 @@ > >> ++/* { dg-do compile } */ > >> ++/* { dg-require-effective-target arm_neon } */ > >> ++/* { dg-add-options arm_neon } */ > >> ++/* { dg-options "-O3" } */ > >> ++ > >> ++int id; > >> ++int > >> ++test (const long int *data) > >> ++{ > >> ++ int i, retval; > >> ++ retval =3D id; > >> ++ for (i =3D 0; i < id; i++) > >> ++ { > >> ++ retval &=3D (data[i] <=3D 0); > >> ++ } > >> ++ > >> ++ return (retval); > >> ++} > >> +-- > >> +2.0.0 > >> + > >> -- > >> 2.0.0 > >> > > --=20 Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com --F02tnJshPGiBzxqM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlPoo0UACgkQN1Ujt2V2gBx2zgCeKNc/M36e6l951amWs3WwZUaq gxgAmwY7MXUeNhRubSvp1v3oUyjc7C9r =6jS2 -----END PGP SIGNATURE----- --F02tnJshPGiBzxqM--