Re: [RFC][PATCH] cmake: drop -fpermissive

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]

On Thu, Aug 14, 2014 at 12:36:42AM +0200, Martin Jansa wrote:
> * it was dropped from default CXXFLAGS in:
>   commit 24dd8e129447013ee98609f3892ec414b1b21340
>   Author: Richard Purdie <richard.purdie@linuxfoundation.org>
>   Date:   Sun Mar 2 17:38:33 2014 +0000
> 
>     bitbake.conf: Drop -fpermissive
> 
>     Drop the -fpermissive C++ compiler flag. We've had this around for years, most
>     code should have been fixed long ago. Its possible some recipes may fail
>     however we can (and should) just use the flag where needed.
> 
> * I haven't build world with this yet, but maybe it's time to
>   drop it here as well at least for consistency

I've noticed that this RFC is already included in master-next.

Good news is, that it didn't cause any new build issues in my world
builds, so I'm fine with it loosing the RFC status.

> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/classes/cmake.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
> index ab2adec..c51b1cf 100644
> --- a/meta/classes/cmake.bbclass
> +++ b/meta/classes/cmake.bbclass
> @@ -16,7 +16,7 @@ OECMAKE_CXX_COMPILER ?= "`echo ${CXX} | sed 's/^\([^ ]*\).*/\1/'`"
>  
>  # Compiler flags
>  OECMAKE_C_FLAGS ?= "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS} ${CFLAGS}"
> -OECMAKE_CXX_FLAGS ?= "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS} ${CXXFLAGS} -fpermissive"
> +OECMAKE_CXX_FLAGS ?= "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS} ${CXXFLAGS}"
>  OECMAKE_C_FLAGS_RELEASE ?= "${SELECTED_OPTIMIZATION} ${CFLAGS} -DNDEBUG"
>  OECMAKE_CXX_FLAGS_RELEASE ?= "${SELECTED_OPTIMIZATION} ${CXXFLAGS} -DNDEBUG"
>  OECMAKE_C_LINK_FLAGS ?= "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS} ${CPPFLAGS} ${LDFLAGS}"
> -- 
> 2.0.4
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]