Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Sven Ebenfeld <sven.ebenfeld@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] md5deep: Add Recipe for md5deep package version 4.4
Date: Mon, 25 Aug 2014 12:14:37 +0200	[thread overview]
Message-ID: <20140825101437.GP20524@jama> (raw)
In-Reply-To: <1408953391-25759-1-git-send-email-sven.ebenfeld@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3641 bytes --]

On Mon, Aug 25, 2014 at 09:56:31AM +0200, Sven Ebenfeld wrote:
> I need to build hashdeep/md5deep within OE to include it in my images. This recipe enables OE to cross-compile md5deep. I needed to add the patch as do_configure_qa is complaining about cross-compilation errors otherwise. I added a pull request for the issue with the variable expansion to hashdeep as well.

Please send this to openembedded-devel@lists.openembedded.org


> Signed-off-by: Sven Ebenfeld <sven.ebenfeld@gmail.com>
> ---
>  .../md5deep/files/wrong-variable-expansion.patch   | 39 ++++++++++++++++++++++
>  meta-oe/recipes-extended/md5deep/md5deep_4.4.bb    | 16 +++++++++
>  2 files changed, 55 insertions(+)
>  create mode 100644 meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch
>  create mode 100644 meta-oe/recipes-extended/md5deep/md5deep_4.4.bb
> 
> diff --git a/meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch b/meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch
> new file mode 100644
> index 0000000..3a4c4f4
> --- /dev/null
> +++ b/meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch
> @@ -0,0 +1,39 @@
> +--- a/configure.ac	2014-08-22 12:22:54.290884351 +0200
> ++++ b/configure.ac	2014-08-22 12:23:15.822306295 +0200
> +@@ -42,18 +42,6 @@
> +      ;;		 		     
> + esac
> + 
> +-
> +-# Bring additional directories where things might be found into our
> +-# search path. I don't know why autoconf doesn't do this by default
> +-if test x"${mingw}" == "xno" ; then
> +-  for spfx in /usr/local /opt/local /sw ; do
> +-    echo checking ${spfx}/include
> +-    if test -d ${spfx}/include; then
> +-        CPPFLAGS="-I${spfx}/include $CPPFLAGS"
> +-        LDFLAGS="-L${spfx}/lib $LDFLAGS"
> +-    fi
> +-  done
> +-fi
> + #
> + #
> + ################################################################
> +@@ -71,7 +59,7 @@
> + 
> + if test $mingw = "no" ; then
> +   # add the warnings we don't want to do on mingw
> +-  $WARNINGS_TO_TEST="$WARNINGS_TO_TEST -Wall -Wstrict-prototypes  -Weffc++"
> ++  WARNINGS_TO_TEST="$WARNINGS_TO_TEST -Wall -Wstrict-prototypes  -Weffc++"
> + fi
> + 
> + for option in $WARNINGS_TO_TEST
> +@@ -105,7 +93,7 @@
> + 
> + if test $mingw = "no" ; then
> +   # add the warnings we don't want to do on mingw
> +-  $WARNINGS_TO_TEST="$WARNINGS_TO_TEST  -Weffc++"
> ++  WARNINGS_TO_TEST="$WARNINGS_TO_TEST  -Weffc++"
> + fi
> + 
> + for option in $WARNINGS_TO_TEST
> diff --git a/meta-oe/recipes-extended/md5deep/md5deep_4.4.bb b/meta-oe/recipes-extended/md5deep/md5deep_4.4.bb
> new file mode 100644
> index 0000000..4e4a2f5
> --- /dev/null
> +++ b/meta-oe/recipes-extended/md5deep/md5deep_4.4.bb
> @@ -0,0 +1,16 @@
> +DESCRIPTION = "md5deep"

Please use better description than just PN (and use SUMMARY if it's
still short).

> +AUTHOR = "Jesse Kornblum, Simson L. Garfinkel"
> +HOMEPAGE = "http://md5deep.sourceforge.net"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=9190f660105b9a56cdb272309bfd5491"
> +
> +inherit autotools
> +
> +SRC_URI = "git://github.com/jessek/hashdeep.git \
> +        file://wrong-variable-expansion.patch \
> +        "
> +
> +# Release 4.4
> +SRCREV = "cd2ed7416685a5e83eb10bb659d6e9bec01244ae"
> +
> +S = "${WORKDIR}/git"
> -- 
> 1.8.1.rc3
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

  reply	other threads:[~2014-08-25 10:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25  7:56 [meta-oe][PATCH] md5deep: Add Recipe for md5deep package version 4.4 Sven Ebenfeld
2014-08-25 10:14 ` Martin Jansa [this message]
2014-08-25 10:51   ` Sven Ebenfeld
2014-08-28  9:39   ` Sven Ebenfeld
2014-08-28 14:36     ` Martin Jansa
2014-08-28 19:43       ` Sven Ebenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140825101437.GP20524@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sven.ebenfeld@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox