Re: [PATCH] Phoronix Test Suite package

[Todd E Brandt <todd.e.brandt@linux.intel.com>]

On Sat, Sep 20, 2014 at 12:03:43AM +0100, Burton, Ross wrote:
> On 19 September 2014 23:44, Todd E Brandt <todd.e.brandt@linux.intel.com> wrote:
> > This is the package recipe for the phoronix test suite v5.2.1. The
> > tool is for benchmarking and testing of the system.
> 
> +RDEPENDS_${PN} = "php-cli"
> 
> Surely phoronix has more dependencies than just php...  Or is this
> just the runner and it talks to slave?  Honestly have no idea how the
> phoronix test suite is structured.

it's designed to be a minimal install with only php as the dependency. It uses
the network to download test definitions and to upload test results.

> 
> +SRC_URI = "http://www.phoronix-test-suite.com/releases/phoronix-test-suite-5.2.1.tar.gz"
> 
> ${BP} expands to PN-PV, so you can replace that with .../releases/${BP}.tar.gz.
> 
> +S = "${WORKDIR}/phoronix-test-suite"
> 
> That's the default value, so you can delete this line.
> 
> +do_install() {
> +       DESTDIR=${D} ./install-sh /usr
> +}
> 
> Use ${exec_prefix} instead of /usr.
> 
> Finally, this is a patch to meta-oe, so it should go to
> openembedded-devel@, not openembedded-core@.

ok, I'll resubmit on the proper list, sorry for the mistake and thanks for the feedback.

> 
> Ross