From: Martin Jansa <martin.jansa@gmail.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] base.bbclass: add SRCREV to do_fetch() hash
Date: Mon, 29 Sep 2014 20:48:35 +0200 [thread overview]
Message-ID: <20140929184835.GU25706@jama> (raw)
In-Reply-To: <CAJTo0LZQCt67M1L7KyPWLoj=fQOf7eccnMsnVioc-kANHD_DLg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
On Mon, Sep 29, 2014 at 06:23:39PM +0100, Burton, Ross wrote:
> On 29 September 2014 18:14, Martin Jansa <martin.jansa@gmail.com> wrote:
> > It will be still mandatory for recipes with multiple SRCREVs (and
> > SRCREV_FORMAT).
>
> Hm, should SRCREV_FORMAT also be in the hash?
That probably won't be enough, you would need to include all
SRCREV_foo
SRCREV_bar
variables when
SRCREV_FORMAT = "foo_bar"
Maybe we can include SRCPV in hash to cover both cases.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
next prev parent reply other threads:[~2014-09-29 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 14:40 [PATCH] base.bbclass: add SRCREV to do_fetch() hash Ross Burton
2014-09-29 14:52 ` Maciej Borzecki
2014-09-29 14:56 ` Burton, Ross
2014-09-29 17:14 ` Martin Jansa
2014-09-29 17:23 ` Burton, Ross
2014-09-29 18:48 ` Martin Jansa [this message]
2014-10-07 18:26 ` Khem Raj
2014-10-07 18:26 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929184835.GU25706@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox