From: Martin Jansa <martin.jansa@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [daisy][PATCH 1/3] layer.conf: Add in useradd dependencies as ABISAFE dependencies
Date: Wed, 1 Oct 2014 06:10:20 +0200 [thread overview]
Message-ID: <20141001041020.GC25706@jama> (raw)
In-Reply-To: <CAMKF1sqa2JtVOhv7f0P=_HfSnrL2kfd2QmP+GM_FsM3zb-xq=g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
On Tue, Sep 30, 2014 at 08:55:53PM -0700, Khem Raj wrote:
> On Tue, Sep 30, 2014 at 6:32 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> > On Tue, Sep 30, 2014 at 06:25:57PM -0700, Khem Raj wrote:
> >> On Tue, Sep 30, 2014 at 5:55 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> >> > This line above ^^^^ has a very long trail of whitespaces and it got commited
> >> > that way, unfortunately :(
> >>
> >> Better was if you commented before it went in.
> >
> > And how would you suggest I was supposed to see it?? Nobody saw it. My email
> > client is no different than others - it doesn't mark trailing whitespaces. The
> > reason I saw it is because I ran "git log -p" on the file and that explicitly
> > highlights trailing whitespaces in BRIGHT RED... :)
>
> just for that may be we should start using gerrit ;)
I'm all for it, it would make my e-mail - review - patchwork -
master-next workflow a lot easier and reliable.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
next prev parent reply other threads:[~2014-10-01 4:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 12:17 [daisy][PATCH 1/3] layer.conf: Add in useradd dependencies as ABISAFE dependencies Steffen Sledz
2014-09-25 12:17 ` [daisy][PATCH 2/3] update-rc.d/systemd: Remove OVERRIDES dependency Steffen Sledz
2014-09-25 12:17 ` [daisy][PATCH 3/3] layer.conf: Mark opkg-utils as ABISAFE for update-alternatives usage Steffen Sledz
2014-10-01 0:55 ` [daisy][PATCH 1/3] layer.conf: Add in useradd dependencies as ABISAFE dependencies Denys Dmytriyenko
2014-10-01 1:25 ` Khem Raj
2014-10-01 1:32 ` Denys Dmytriyenko
2014-10-01 3:55 ` Khem Raj
2014-10-01 4:10 ` Martin Jansa [this message]
2014-10-01 8:12 ` Richard Purdie
2014-10-01 11:02 ` Koen Kooi
2014-10-01 15:34 ` Martin Jansa
2014-10-03 8:24 ` Koen Kooi
2014-10-03 14:03 ` Trevor Woerner
2014-10-03 16:46 ` Khem Raj
2014-10-01 13:12 ` Peter A. Bigot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001041020.GC25706@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox