From: Laurentiu Palcu <laurentiu.palcu@intel.com>
To: Pascal Bach <pascal.bach@siemens.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] image.py: Fix error in graph sorting
Date: Fri, 24 Oct 2014 14:54:43 +0300 [thread overview]
Message-ID: <20141024115443.GA16788@lpalcu-linux> (raw)
In-Reply-To: <1414136470-3075-1-git-send-email-pascal.bach@siemens.com>
On Fri, Oct 24, 2014 at 09:41:10AM +0200, Pascal Bach wrote:
> The graph sorting algorithm for image dependencies does a look for an
> occurrence of a searched string instead of comparing the chunk to the
> searched string. This leads to the problem that ubifs is recognized as ubi aswell.
>
> This fixes this by splitting up the string into chunks.
>
> Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
Reviewed-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
> ---
> meta/lib/oe/image.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oe/image.py b/meta/lib/oe/image.py
> index c9b9033..5e07187 100644
> --- a/meta/lib/oe/image.py
> +++ b/meta/lib/oe/image.py
> @@ -109,7 +109,7 @@ class ImageDepGraph(object):
> # remove added nodes from deps_array
> for item in group:
> for node in self.graph:
> - if item in self.graph[node]:
> + if item in self.graph[node].split():
> self.deps_array[node][0] -= 1
>
> self.deps_array.pop(item, None)
> --
> 1.7.10.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
prev parent reply other threads:[~2014-10-24 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 7:41 [PATCH] image.py: Fix error in graph sorting Pascal Bach
2014-10-24 11:54 ` Laurentiu Palcu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024115443.GA16788@lpalcu-linux \
--to=laurentiu.palcu@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pascal.bach@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox