From: Martin Jansa <martin.jansa@gmail.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCHv2 4/4] recipes-qt: add x11 to required DISTRO_FEATURES
Date: Thu, 22 Jan 2015 17:34:28 +0100 [thread overview]
Message-ID: <20150122163428.GF2456@jama> (raw)
In-Reply-To: <CAJTo0LamxpYW0uHzTRTjyJZgw7_meZbx5L=2mZ_LwdzRcv-vkg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
On Tue, Jan 20, 2015 at 09:19:32PM +0000, Burton, Ross wrote:
> On 10 December 2014 at 14:18, Martin Jansa <martin.jansa@gmail.com> wrote:
>
> > +++ b/meta/recipes-qt/qt4/qt4-x11-free.inc
> > @@ -8,6 +8,9 @@ DEPENDS += "virtual/libgl virtual/libx11 fontconfig libxft
> > libxext libxrender li
> > PROVIDES += "qt4-x11"
> > QT4DEPENDS = ""
> >
> > +# depends on virtual/libx11
> > +REQUIRED_DISTRO_FEATURES = "x11"
> > +
> >
>
> Isn't that redundant as qt4x11 already sets REQUIRED_DISTRO_FEATURES?
>
> Also, if setting REQURED_DISTRO_FEATURES in a class, using += or _append
> seems like a sensible idea for future-proofing.
Done, good catch.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
next prev parent reply other threads:[~2015-01-22 16:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 13:42 [PATCH 1/4] xorg-app: add x11 to required DISTRO_FEATURES and cleanup dependencies Martin Jansa
2014-07-24 13:42 ` [PATCH 2/4] recipes: add x11 to required DISTRO_FEATURES Martin Jansa
2014-07-24 13:52 ` Burton, Ross
2014-07-24 15:22 ` Martin Jansa
2014-07-28 13:18 ` Richard Purdie
2014-08-06 11:48 ` Martin Jansa
2014-10-30 13:20 ` Martin Jansa
2014-10-30 13:28 ` Richard Purdie
2014-10-30 14:18 ` Koen Kooi
2014-11-11 17:13 ` Martin Jansa
2014-12-10 14:18 ` [PATCHv2 1/4] xorg-app: add x11 to required DISTRO_FEATURES and cleanup dependencies Martin Jansa
2014-12-10 14:18 ` [PATCHv2 2/4] recipes: add x11 to required DISTRO_FEATURES Martin Jansa
2015-01-20 21:17 ` Burton, Ross
2015-01-21 12:27 ` Martin Jansa
2014-12-10 14:18 ` [PATCHv2 3/4] xorg-driver: " Martin Jansa
2015-01-20 21:17 ` Burton, Ross
2015-01-22 16:34 ` Martin Jansa
2015-01-23 12:46 ` Burton, Ross
2014-12-10 14:18 ` [PATCHv2 4/4] recipes-qt: " Martin Jansa
2015-01-20 21:19 ` Burton, Ross
2015-01-22 16:34 ` Martin Jansa [this message]
2015-01-18 17:06 ` [PATCHv2 1/4] xorg-app: add x11 to required DISTRO_FEATURES and cleanup dependencies Martin Jansa
2015-01-20 20:12 ` Burton, Ross
2014-07-24 13:42 ` [PATCH 3/4] xorg-driver: add x11 to required DISTRO_FEATURES Martin Jansa
2014-07-24 13:47 ` Burton, Ross
2014-07-24 13:42 ` [PATCH 4/4] recipes-qt: " Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122163428.GF2456@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox