From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Tom Zanussi <tom.zanussi@linux.intel.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] wic: use kB for the partitions size
Date: Wed, 4 Feb 2015 19:42:05 +0100 [thread overview]
Message-ID: <20150204184205.GA4443@piout.net> (raw)
In-Reply-To: <1423074778.18649.24.camel@picadillo>
On 04/02/2015 at 12:32:58 -0600, Tom Zanussi wrote :
> On Wed, 2015-02-04 at 00:40 +0100, Alexandre Belloni wrote:
> > Use kB instead of MB for the partition size to get a better granularity.
> >
> > This is needed on some SoC (i.mx, omap) where it is necessary to create
> > partitions as small as 64kB.
> >
> > Keep the backward compatibility by assuming MB when no unit is provided.
> >
>
> Looks fine to me, and a quick test shows expected sizes, etc.
>
> But please do update at least the in-tool help (/lib/image/help.py) with
> the new --size options.
Sure, I will do. I just realized it existed ;)
Thanks for the review.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-02-04 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 23:40 [PATCH] wic: use kB for the partitions size Alexandre Belloni
2015-02-04 10:29 ` Maciej Borzecki
2015-02-04 10:53 ` Alexandre Belloni
2015-02-04 18:32 ` Tom Zanussi
2015-02-04 18:42 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204184205.GA4443@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox