Re: [PATCH] wic: allow creation of partitions not in table

[Maciej Borzecki <maciej.borzecki@open-rnd.pl>]

On 02/05 00:03, Alexandre Belloni wrote:
> For some architectures it is necessary to reserve space on disk without
> it being present in the partition table.
>
> For example, u-boot on i.mx is placed at an offset of 1kB on the sdcard.
> While it would be possible to create a partition at that offset and
> place u-boot there, it would then be necessary to update the default
> u-boot environment to use partition 2 on the mmc instead of partition
> 1.

I'm wondering if reusing parition here is the right choice. How about
making this a separate command, since the operation of putting some
binary data at a particular location within the image sounds like
something very specific to wic.

Could name it 'raw-copy', with options --source and --offset. The
command would be applied after image assembly is complete. Offset could
be expressed in bytes by default (plus k/M/G suffix). Source could
either be a 'bootloader', that implies a default bootloader for this
target, or a name of a file from $DEPLOY_DIR_IMAGE.

Assuming IMAGE_BOOTLOADER='u-boot.img' is set somewhere, the kickstart
could look like:

part / --source rootfs --ondisk mmcblk --fstype=ext4 --label root --align 4 --start 1M
raw-copy --source bootloader --offset 1kB


If at some point we extend the bootloader command to include the name of
bootloader file:

part / --source rootfs --ondisk mmcblk --fstype=ext4 --label root --align 4 --start 1M
bootloader --name u-boot.img
raw-copy --source bootloader --offset 1kB

What do you think?

--
Maciej Borzęcki
Senior Software Developer at Open-RnD Sp. z o.o., Poland
www.open-rnd.pl
mobile: +48 889 117 365, fax: +48 42 657 9079


Niniejsza wiadomość wraz z załącznikami może
zawierać chronione prawem lub poufne informacje i została
wysłana wyłącznie do wiadomości i użytku osób, do których
została zaadresowana. Jeśli wiadomość została otrzymana
przypadkowo zabrania się jej kopiowania lub rozsyłania do osób
trzecich. W takim przypadku uprasza się o natychmiastowe
zniszczenie wiadomości oraz poinformowanie nadawcy o
zaistniałej sytuacji za pomocą wiadomości zwrotnej.
Dziękujemy.

This message, including any attachments hereto,
may contain privileged or confidential information and is sent
solely for the attention and use of the intended addressee(s).
If you are not an intended addressee, you may neither use this
message nor copy or deliver it to anyone. In such case, you
should immediately destroy this message and kindly notify the
sender by reply email. Thank you.