Re: [PATCH] mozjs: fix build failure due to missing dependency on libxt

[Paul Gortmaker <paul.gortmaker@windriver.com>]

[Re: [OE-core] [PATCH] mozjs: fix build failure due to missing dependency on libxt] On 12/02/2015 (Thu 14:56) Peter Urbanec wrote:

> On 12/02/15 11:00, Paul Gortmaker wrote:
> >Looking at the configure script, we see these invalid values are output
> >when the autoconf test for X11 fails.  That test fails in the following
> >fashion:
> ...
> >Since the package clearly has never been built in a no-X11 OE environment,
> >we assume that all OE users to date are X11 users and hence simply add a
> >dependency on libxt.
> 
> I've run into this problem quite a while ago. My fix for this was a
> .bbappend file that passes --without-x to configure, since my target
> has no X11.
> 

Since it isn't a run time dependency, your local tweak to select a non-X
build of the package should still give you that even with the libxt
build dependency added.  My point still stands that in its current
state, the only successful builds have been X11-enabled ones;  so my
patch fixes the random build failures without changing the build output.

If we want to come at mozjs and enhance it at the same time to support
non-x11 without the need for an append like  you are using, we'd need
to do something like:

DEPENDS_append = "${@bb.utils.contains('DISTRO_FEATURES','x11','libxt','',d)}"

...or perhaps:

EXTRA_OECONF_X = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '--with-x', '--without-x', d)}"

I've not tested either of the above; I've just found them in existing
recipes; I'll wait to see if the maintainers have any preference for one
of the three possible solutions (the original and now the above two) as
doing one of the above two now implies we are supporting non-x11 builds
of it, when clearly we were not up to this point.

Paul.