Re: [PATCH] gstreamer1.0*git: Update to build current AUTOREV from master branch.

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2297 bytes --]

On Fri, Feb 27, 2015 at 11:27:06PM +1100, Peter Urbanec wrote:
> On 27/02/15 20:35, Andreas Oberritter wrote:
> > as far as I remember, OE-Core policy forbids AUTOREV in recipes, because
> > it would make network access mandatory.
> 
> Fair enough. If that is the policy, it would probably be appropriate to 
> move the gstreamer1.01-*_git.bb recipes out of oe-core or at least fix 
> them so that it is possible to use ${AUTOREV} from another layer.
> 
> > The syntax for enabling it from local.conf is:
> > SRCREV_pn-gstreamer1.0 = "${AUTOREV}"
> 
> This only works for the main gstreamer1.0 recipe. It fails with infinite 
> recursion on any of the gstreamer1.0-plugins-*.bb recipes as I mentioned 
> before. This is because the plugins use a python method for SRC_URI 
> which references PV. This blows up when you try to use SRCREV="${AUTOREV}"
> 
> I guess the question is what next? Should I just drop this and leave the 
> oe-core gstreamer1.0*git.bb recipes as they are (referencing git commits 
> from circa 2013) or should I put a bit more effort into cleaning up the 

I think the best compromise is to apply your changes, but instead of
setting SRCREV to AUTOREV set it to some recent revision you've tested
locally.

Then someone can apply AUTOREV from distro config or if we cannot work
around infinite recursion, then you can still set it to AUTOREV in
.bbappend.

Cheers,

> issues with infinite recursion when used with AUTOREV? I suspect that 
> the cleanup will just involve removing the current code and inserting a 
> bunch of conditionals that translate "gstreamer1.0-" to "gst-"
> 
> In my opinion the current version of the recipes is of limited value. I 
> understand that there has recently been some activity on implementing 
> something that could deliver the functionality of gitpkgv at the oe-core 
> level. Should I perhaps just wait and see how that pans out? 
> gstreamer1.0*git.bb could be a good test case. ;-)
> 
> Cheers and beers,
> 
> 	Peter
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]