Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] lib/oe/lsb.py: Stop parsing /etc/SuSE-release
Date: Fri, 20 Mar 2015 16:12:47 +0200	[thread overview]
Message-ID: <20150320141247.GA13743@linux.intel.com> (raw)
In-Reply-To: <1715446.SMLV1DZGVq@peggleto-mobl.ger.corp.intel.com>

On Fri, Mar 20, 2015 at 11:38:25AM +0000, Paul Eggleton wrote:
> Hi Ed,
> 
> On Friday 20 March 2015 13:22:50 Ed Bartosh wrote:
> > /etc/SuSE-release should not be parsed to obtain release info
> > 
> > Here is the quote from /etc/SuSE-release:
> > /etc/SuSE-release is deprecated and will be removed in the future,
> > use /etc/os-release instead
> > 
> > All recent OpenSUSE versions already have /etc/os-release and
> > oe.lsb/release_dict_file function already parses it.
> > 
> > Current implementation of release_dict_file returns different values
> > when parsing /etc/SuSE-release and /etc/os-release. This is one more
> > advantage of getting rid of parsing /etc/SuSE-release.
> 
> How long ago did OpenSuSE start including /etc/os-release? My concern is if 
> someone did happen to run on an older OpenSuSE release and then submit a bug 
> report with an attached log, we'd rather see the actual version rather than 
> "Unknown". If that's a possible scenario, we might want to just swap the 
> blocks around so that /etc/os-release is looked for first.
> 
I've checked opensuse versions starting from 12.3, which was released 2 years ago and became OOL in Jan 2015. If you think it's not enough I can check 12.2 and 12.1 or swap the blocks as you've suggested.

Regards,
Ed


  reply	other threads:[~2015-03-20 14:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 11:22 [PATCH] lib/oe/lsb.py: Stop parsing /etc/SuSE-release Ed Bartosh
2015-03-20 11:38 ` Paul Eggleton
2015-03-20 14:12   ` Ed Bartosh [this message]
2015-03-20 18:37     ` [PATCH] lib/oe/lsb.py: Prioritize parsing of /etc/os-release Ed Bartosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150320141247.GA13743@linux.intel.com \
    --to=ed.bartosh@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox