From: Martin Jansa <martin.jansa@gmail.com>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] glibc: fix a tpo
Date: Thu, 2 Apr 2015 06:37:46 +0200 [thread overview]
Message-ID: <20150402043746.GN14928@jama> (raw)
In-Reply-To: <551CB39B.1000500@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 3755 bytes --]
On Thu, Apr 02, 2015 at 11:12:27AM +0800, Robert Yang wrote:
>
>
> On 04/02/2015 01:59 AM, Martin Jansa wrote:
> > On Wed, Apr 01, 2015 at 12:53:02AM -0700, Robert Yang wrote:
> >> Fixed a typo:
> >> name-target-directory -> make-target-directory
> >
> > You have another typo in commit message.
>
> Sorry, I checked again, which typo, please ?
"fix a TPO"
> // Robert
>
> >
> >> There is no name-target-directory, it should be make-target-directory,
> >> this fixed the error:
> >> /bin/bash: /path/to/elf/runtime-linker.T: No such file or directory
> >> Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed
> >>
> >> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> >> ---
> >> .../glibc/glibc/elf-Makefile-fix-a-typo.patch | 36 ++++++++++++++++++++
> >> meta/recipes-core/glibc/glibc_2.21.bb | 1 +
> >> 2 files changed, 37 insertions(+)
> >> create mode 100644 meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch
> >>
> >> diff --git a/meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch b/meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch
> >> new file mode 100644
> >> index 0000000..ec48006
> >> --- /dev/null
> >> +++ b/meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch
> >> @@ -0,0 +1,36 @@
> >> +From 6207fb45553ee98f2f326883b7c21b76c8267343 Mon Sep 17 00:00:00 2001
> >> +From: Robert Yang <liezhi.yang@windriver.com>
> >> +Date: Tue, 31 Mar 2015 02:31:25 -0700
> >> +Subject: [PATCH] elf/Makefile: fix a typo
> >> +
> >> +Fixed a typo:
> >> +name-target-directory -> make-target-directory
> >> +
> >> +There is no name-target-directory, it should be make-target-directory,
> >> +this fixed the error:
> >> +/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory
> >> +Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed
> >> +
> >> +Upstream-Status: Pending
> >> +
> >> +Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> >> +---
> >> + elf/Makefile | 2 +-
> >> + 1 file changed, 1 insertion(+), 1 deletion(-)
> >> +
> >> +diff --git a/elf/Makefile b/elf/Makefile
> >> +index e5b142c..62fe245 100644
> >> +--- a/elf/Makefile
> >> ++++ b/elf/Makefile
> >> +@@ -358,7 +358,7 @@ $(objpfx)interp.os: $(elf-objpfx)runtime-linker.h
> >> +
> >> + $(elf-objpfx)runtime-linker.h: $(elf-objpfx)runtime-linker.st; @:
> >> + $(elf-objpfx)runtime-linker.st: $(common-objpfx)config.make
> >> +- $(name-target-directory)
> >> ++ $(make-target-directory)
> >> + echo '#define RUNTIME_LINKER "$(rtlddir)/$(rtld-installed-name)"' \
> >> + > ${@:st=T}
> >> + $(move-if-change) ${@:st=T} ${@:st=h}
> >> +--
> >> +1.7.9.5
> >> +
> >> diff --git a/meta/recipes-core/glibc/glibc_2.21.bb b/meta/recipes-core/glibc/glibc_2.21.bb
> >> index 91feff5..fcef4ff 100644
> >> --- a/meta/recipes-core/glibc/glibc_2.21.bb
> >> +++ b/meta/recipes-core/glibc/glibc_2.21.bb
> >> @@ -25,6 +25,7 @@ SRC_URI = "git://sourceware.org/git/glibc.git;branch=${BRANCH} \
> >> file://0001-Add-unused-attribute.patch \
> >> file://0001-When-disabling-SSE-also-make-sure-that-fpmath-is-not.patch \
> >> file://0001-yes-within-the-path-sets-wrong-config-variables.patch \
> >> + file://elf-Makefile-fix-a-typo.patch \
> >> ${EGLIBCPATCHES} \
> >> "
> >> EGLIBCPATCHES = "\
> >> --
> >> 1.7.9.5
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
next prev parent reply other threads:[~2015-04-02 4:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 7:52 [PATCH 0/3] meta: 3 fixes Robert Yang
2015-04-01 7:53 ` [PATCH 1/3] piglit: add PACKAGECONFIG for freeglut Robert Yang
2015-04-01 17:59 ` Martin Jansa
2015-04-02 3:24 ` Robert Yang
2015-04-02 11:10 ` Burton, Ross
2015-04-04 3:32 ` Robert Yang
2015-04-01 7:53 ` [PATCH 2/3] db: fix parallel issue Robert Yang
2015-04-01 7:53 ` [PATCH 3/3] glibc: fix a tpo Robert Yang
2015-04-01 17:59 ` Martin Jansa
2015-04-02 3:12 ` Robert Yang
2015-04-02 4:37 ` Martin Jansa [this message]
2015-04-02 5:09 ` Robert Yang
2015-04-02 22:15 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402043746.GN14928@jama \
--to=martin.jansa@gmail.com \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox