Re: [PATCH 1/2] classes/package: clarify installed-vs-shipped message

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2070 bytes --]

On Mon, Apr 13, 2015 at 04:44:52PM +0100, Paul Eggleton wrote:
> Based on the number of times I've had to explain it over the years it
> seems that a lot of new users don't immediately realise what is meant
> by "shipped" here (nor should we expect them to) so let's at least
> mention packaging and briefly tell the user what they need to do. (I was
> going to go into more detail in the message, but there is really more
> detail than can be covered succinctly here.)
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  meta/classes/package.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 5558d0d..9790e9d 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -1132,12 +1132,13 @@ python populate_packages () {
>                  unshipped.append(path)
>  
>      if unshipped != []:
> -        msg = pn + ": Files/directories were installed but not shipped"
> +        msg = pn + ": Files/directories were installed but not shipped in any package:"
>          if "installed-vs-shipped" in (d.getVar('INSANE_SKIP_' + pn, True) or "").split():
>              bb.note("Package %s skipping QA tests: installed-vs-shipped" % pn)
>          else:
>              for f in unshipped:
>                  msg = msg + "\n  " + f
> +            msg = msg + "\nPlease either set FILES such that these items are packaged, or alternatively delete them within do_install"

We should also mention the possibility to fix Makefile.am,
CMakeLists.txt, ... not to install them in first place.

>              package_qa_handle_error("installed-vs-shipped", msg, d)
>  }
>  populate_packages[dirs] = "${D}"
> -- 
> 2.1.0
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]