From: Martin Jansa <martin.jansa@gmail.com>
To: Dmitry Eremin-Solenikov <dmitry_eremin@mentor.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] qt4-x11-free: make virtual/libgl dependecy conditional
Date: Fri, 24 Apr 2015 23:20:13 +0200 [thread overview]
Message-ID: <20150424212013.GF2353@jama> (raw)
In-Reply-To: <1429905741-24667-1-git-send-email-dmitry_eremin@mentor.com>
On Fri, Apr 24, 2015 at 11:02:21PM +0300, Dmitry Eremin-Solenikov wrote:
> Make qt4-x11-free depend on virtual/libgl only if the DISTRO_FEATURES
> contain opengl. Otherwise there will be no package to fullfil this
> dependency.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dmitry_eremin@mentor.com>
> ---
> meta/recipes-qt/qt4/qt4-x11-free.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-qt/qt4/qt4-x11-free.inc b/meta/recipes-qt/qt4/qt4-x11-free.inc
> index 3b1e0fe..835fc96 100644
> --- a/meta/recipes-qt/qt4/qt4-x11-free.inc
> +++ b/meta/recipes-qt/qt4/qt4-x11-free.inc
> @@ -4,7 +4,8 @@ SUMMARY = "Cross-platform UI toolkit and application framework (X11 version)"
> DESCRIPTION = "Qt is a versatile cross-platform application framework -- this is the X11 version."
> HOMEPAGE = "http://qt-project.org/"
> SECTION = "x11/libs"
> -DEPENDS += "virtual/libgl virtual/libx11 fontconfig libxft libxext libxrender libxrandr libxcursor"
> +DEPENDS += "virtual/libx11 fontconfig libxft libxext libxrender libxrandr libxcursor"
> +DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)}"
That still leaves opengl support to be autodetected from sysroot for
distributions without opengl in DISTRO_FEATURES but where someone built
virtual/libgl provider before qt4-x11-free.
You need to use PACKAGECONFIG to explicitly disable it when it should be
disabled based on DISTRO_FEATURES.
> PROVIDES += "qt4-x11"
> QT4DEPENDS = ""
>
> --
> 2.1.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
next prev parent reply other threads:[~2015-04-24 21:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 20:02 [PATCH] qt4-x11-free: make virtual/libgl dependecy conditional Dmitry Eremin-Solenikov
2015-04-24 21:20 ` Martin Jansa [this message]
2015-04-25 10:14 ` Dmitry Eremin-Solenikov
-- strict thread matches above, loose matches on Subject: below --
2015-05-11 19:50 Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150424212013.GF2353@jama \
--to=martin.jansa@gmail.com \
--cc=dmitry_eremin@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox