From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by mail.openembedded.org (Postfix) with ESMTP id 1101F73BB9 for ; Tue, 28 Apr 2015 02:48:05 +0000 (UTC) Received: from mail.nefkom.net (unknown [192.168.8.184]) by mail-out.m-online.net (Postfix) with ESMTP id 3lbRzf3vzNz3hht4; Tue, 28 Apr 2015 04:40:46 +0200 (CEST) X-Auth-Info: MzgCQzRKQyqGtcIMpI1SgyHfi/8LmAPIj0AcWx4h9TQ= Received: from chi.localnet (unknown [195.140.253.167]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mnet-online.de (Postfix) with ESMTPSA id 3lbRzf2cHMzvhTg; Tue, 28 Apr 2015 04:40:46 +0200 (CEST) From: Marek Vasut To: Koen Kooi Date: Tue, 28 Apr 2015 04:39:32 +0200 User-Agent: KMail/1.13.7 (Linux/3.13-trunk-amd64; KDE/4.13.1; x86_64; ; ) References: <1413746147-7120-1-git-send-email-marex@denx.de> <201410262352.34958.marex@denx.de> In-Reply-To: MIME-Version: 1.0 Message-Id: <201504280439.32255.marex@denx.de> Cc: Paul Eggleton , openembedded-core@lists.openembedded.org Subject: Re: [PATCH 4/7] kernel: Pull uImage generation into separate class X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2015 02:48:07 -0000 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Monday, October 27, 2014 at 07:59:42 AM, Koen Kooi wrote: Hi! sorry for the very late reply. > > So uh, what exactly would you propose then? Ask the BSPs to cater for the > > change ? I don't quite like that option, since it's like breaking an API > > (or similar interface, I'm not sure what the local equivalent of that > > would be). > > Personally, I'd try to keep the kernel_foo() methods the same since those > are very popular, a lot of BSPs append the configure one. So maybe > something like: > > kernel.bbclass: > do_configure > do_install > addtask > etc > inherit kernel-${KERNEL_IMAGETYPE.bbclass} > > kernel-${KERNEL_IMAGETYPE.bbclass} > do_install (overrides the one in kernel.bbclass) > > Someone more familiar with bbclass method (re)naming and scoping should > weigh in on the method override above, but I think it should work. I wonder, is it possible to inherit bbclass if it exists as a file and inherit nothing otherwise ? In case I do: inherit kernel-${@d.getVar("KERNEL_IMAGETYPE", True).lower()} I get a nasty spit from bitbake in case I'm building with zImage KERNEL_IMAGETYPE . The reason is obvious, the file kernel-zimage.bbclass doesn't exist. So I wonder if there's some easy way to check if the class actually exists. Best regards, Marek Vasut