Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Anders Darander <anders@chargestorm.se>
To: Bruno Bottazzini <bruno.bottazzini@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V4 3/3] systemd: split modules into packages
Date: Tue, 12 May 2015 11:12:38 +0200	[thread overview]
Message-ID: <20150512091238.GA8861@ad.chargestorm.se> (raw)
In-Reply-To: <1431367371-7716-4-git-send-email-bruno.bottazzini@intel.com>

* Bruno Bottazzini <bruno.bottazzini@intel.com> [150511 20:03]:

> diff --git a/meta/recipes-core/systemd/systemd_219.bb b/meta/recipes-core/systemd/systemd_219.bb
> index 6ed4fe0..e83601f 100644
> --- a/meta/recipes-core/systemd/systemd_219.bb
> +++ b/meta/recipes-core/systemd/systemd_219.bb
> @@ -19,7 +19,18 @@ PROVIDES = "udev"

>  PE = "1"

> -DEPENDS = "kmod docbook-sgml-dtd-4.1-native intltool-native gperf-native acl readline dbus libcap libcgroup glib-2.0 qemu-native util-linux"
> +DEPENDS = "intltool-native \
> +           gperf-native \
> +           readline \
> +           libcgroup \
> +           libcap \
> +           qemu-native \
> +           ${@bb.utils.contains('PACKAGECONFIG', 'dbus', 'dbus', '', d)} \
> +           ${@bb.utils.contains('PACKAGECONFIG', 'kmod', 'kmod', '', d)} \
> +           ${@bb.utils.contains('PACKAGECONFIG', 'manpages', 'docbook-sgml-dtd-4.1-native', '', d)} \
> +           ${@bb.utils.contains('PACKAGECONFIG', 'acl', 'acl', '', d)} \
> +           ${@bb.utils.contains('PACKAGECONFIG', 'glib', 'glib-2.0', '', d)} \
> +           ${@bb.utils.contains('PACKAGECONFIG', 'blkid', 'util-linux', '', d)}"

These lines should be removed. The 3rd parameter in the PACKAGECONFIG[]
definitions below, do automatically get added to DEPENDS if the
respective PACKAGECONFIG is enabled. Thus, you don't need to check for
it yourself in DEPENDS.

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB / eStorm AB


      reply	other threads:[~2015-05-12  9:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 18:02 [PATCH V4 0/3] systemd: split modules into packages Bruno Bottazzini
2015-05-11 18:02 ` [PATCH V4 1/3] dbus: split tools package Bruno Bottazzini
2015-05-11 22:04   ` Phil Blundell
2015-05-11 22:24     ` Bottazzini, Bruno
2015-05-11 18:02 ` [PATCH V4 2/3] systemd: removing workaround odering journal after remote-fs.target Bruno Bottazzini
2015-05-11 18:02 ` [PATCH V4 3/3] systemd: split modules into packages Bruno Bottazzini
2015-05-12  9:12   ` Anders Darander [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512091238.GA8861@ad.chargestorm.se \
    --to=anders@chargestorm.se \
    --cc=bruno.bottazzini@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox