Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Drew Moseley <drew_moseley@mentor.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] mesa: Add blank r600 PACKAGECONFIG
Date: Mon, 29 Jun 2015 21:32:48 +0200	[thread overview]
Message-ID: <20150629193248.GG2393@jama> (raw)
In-Reply-To: <1435602230-12093-1-git-send-email-drew_moseley@mentor.com>

[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]

On Mon, Jun 29, 2015 at 02:23:50PM -0400, Drew Moseley wrote:
> Fixes warnings such as:
>     WARNING: mesa: invalid PACKAGECONFIG: r600
> when building with the r600 configuration.

Shouldn't you fix your PACKAGECONFIG value instead (wherever it's set to
include r600)?

> 
> Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
> ---
>  meta/recipes-graphics/mesa/mesa.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
> index 97ed02f..09e80e8 100644
> --- a/meta/recipes-graphics/mesa/mesa.inc
> +++ b/meta/recipes-graphics/mesa/mesa.inc
> @@ -53,6 +53,7 @@ PACKAGECONFIG[openvg] = "--enable-openvg, --disable-openvg"
>  
>  GALLIUMDRIVERS = "swrast"
>  GALLIUMDRIVERS_LLVM33 = "${@bb.utils.contains('PACKAGECONFIG', 'r600', 'radeonsi,r600', '', d)}"
> +PACKAGECONFIG[r600] = ""
>  GALLIUMDRIVERS_LLVM33_ENABLED = "${@base_version_less_or_equal('MESA_LLVM_RELEASE', '3.2', False, len('${GALLIUMDRIVERS_LLVM33}') > 0, d)}"
>  GALLIUMDRIVERS_LLVM = "r300,svga,nouveau${@',${GALLIUMDRIVERS_LLVM33}' if ${GALLIUMDRIVERS_LLVM33_ENABLED} else ''}"
>  GALLIUMDRIVERS_append_x86 = "${@bb.utils.contains('PACKAGECONFIG', 'gallium-llvm', ',${GALLIUMDRIVERS_LLVM}', '', d)}"
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

  reply	other threads:[~2015-06-29 19:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29 18:23 [PATCH] mesa: Add blank r600 PACKAGECONFIG Drew Moseley
2015-06-29 19:32 ` Martin Jansa [this message]
2015-06-29 19:44   ` Moseley, Drew
2015-06-29 20:07     ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150629193248.GG2393@jama \
    --to=martin.jansa@gmail.com \
    --cc=drew_moseley@mentor.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox