Re: [PATCH] watchdog: kill update-rc.d when not using sysvinit

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2421 bytes --]

On Wed, Jul 29, 2015 at 12:27:15PM -0700, Christopher Larson wrote:
> On Wed, Jul 29, 2015 at 11:35 AM, Burton, Ross <ross.burton@intel.com>
> wrote:
> 
> > On 29 July 2015 at 19:05, Rehman, Abdur <Abdur_Rehman@mentor.com> wrote:
> >
> >> watchdog_5.14.bb does not inherit systemd, and so
> >> INHIBIT_UPDATERCD_BBCLASS does
> >> not get set.
> >>
> >> While trying to build watchdog with systemd in DISTRO_FEATURES but not
> >> sysvinit,
> >> following warning is observed:
> >>     WARNING: QA Issue: watchdog rdepends on initscripts-functions, but
> >> it isn't
> >>     a build dependency? [build-deps]
> >>
> >> Since sysvinit is not in DISTRO_FEATURES and INHIBIT_UPDATERCD_BBCLASS is
> >> not
> >> set, the logic in update-rc.d.bbclass goes on to add an rdep for watchdog
> >> on
> >> initscripts-functions, inside update_rcd_package(). And this results in
> >> the
> >> QA warning.
> >>
> >
> > When a class inherits update-rcd but not systemd, and the distro is
> > systemd only, update-rcd still runs (and has still run) as otherwise you
> > don't get any init scripts.  Setting inhibit will remove the init scripts,
> > and the watchdog daemon won't start.  I'm pretty sure this isn't what you
> > intended.
> >
> > Are you overriding VIRTUAL-RUNTIME_initscripts in your distro?  update-rcd
> > adds a dependency on that when it is inherited, which by default is
> > initscripts, so you get your build dependency there.  I suspect your distro
> > is overriding that variable when perhaps it shouldn't be.
> >
> 
> I don’t think we really want initscripts installed in a systemd-only
> distro, particularly if systemd is built with sysvcompat enabled, as we
> don’t want to run the sysvinit scripts for services which are already
> covered by systemd proper, unless I’m missing something?

I agree and as work-around for this and similar issues I'm setting empty
VIRTUAL-RUNTIME_initscripts in systemd-only distros.

> -- 
> Christopher Larson
> kergoth at gmail dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics

> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]