From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: "Ahsan, Noor" <Noor_Ahsan@mentor.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 12/17] image_types.bbclass: add wic image type
Date: Wed, 26 Aug 2015 18:54:53 +0300 [thread overview]
Message-ID: <20150826155453.GA17207@linux.intel.com> (raw)
In-Reply-To: <365E1805BC95084CBE82381A0B86999401095CC0C4@EU-MBX-01.mgc.mentorg.com>
On Tue, Aug 25, 2015 at 05:46:08PM +0000, Ahsan, Noor wrote:
> Would it not be better approach if we don't hardcore the name and path and handle it using some variable?
>
Can you elaborate a bit? I don't see any hardcoded names and paths in
this patch.
Regards,
Ed
> Noor
>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Ed Bartosh
> Sent: Tuesday, August 25, 2015 2:04 PM
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH 12/17] image_types.bbclass: add wic image type
>
> wic image type is used to produce partitioned images.
>
> Image configuration should be stored in either <recipe>.<machine>.wks or <recipe>.wks file.
> .wks file should be put to the same location as image recipe and have the same name.
>
> [YOCTO #7672]
>
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
> meta/classes/image_types.bbclass | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 8547574..cdd66ff 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -154,6 +154,16 @@ IMAGE_CMD_ubi = "multiubi_mkfs "${MKUBIFS_ARGS}" "${UBINIZE_ARGS}" "${UBI_VOLNAM
>
> IMAGE_CMD_ubifs = "mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubifs ${MKUBIFS_ARGS}"
>
> +IMAGE_CMD_wic () {
> + out=${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}
> + wks=${FILE_DIRNAME}/${IMAGE_BASENAME}.${MACHINE}.wks
> + [ -e $wks ] || wks=${FILE_DIRNAME}/${IMAGE_BASENAME}.wks
> + [ -e $wks ] || bbfatal "Kiskstart file $wks doesn't exist"
> + BUILDDIR=${TOPDIR} wic create $wks --vars ${STAGING_DIR_TARGET}/imgdata/ -e ${IMAGE_BASENAME} -o $out/
> + mv $out/build/${IMAGE_BASENAME}*.direct $out.rootfs.wic
> + rm -rf $out/
> +}
> +
> EXTRA_IMAGECMD = ""
>
> inherit siteinfo
> @@ -182,6 +192,7 @@ IMAGE_DEPENDS_elf = "virtual/kernel mkelfimage-native"
> IMAGE_DEPENDS_ubi = "mtd-utils-native"
> IMAGE_DEPENDS_ubifs = "mtd-utils-native"
> IMAGE_DEPENDS_multiubi = "mtd-utils-native"
> +IMAGE_DEPENDS_wic = "parted-native"
>
> # This variable is available to request which values are suitable for IMAGE_FSTYPES IMAGE_TYPES = " \ @@ -201,6 +212,7 @@ IMAGE_TYPES = " \
> vdi \
> qcow2 \
> elf \
> + wic wic.gz wic.bz2 wic.lzma \
> "
>
> COMPRESSIONTYPES = "gz bz2 lzma xz lz4 sum"
> --
> 2.1.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
--
Regards,
Ed
next prev parent reply other threads:[~2015-08-26 15:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 9:04 [PATCH v2 00/17] Build wic images with bitbake Ed Bartosh
2015-08-25 9:04 ` [PATCH 01/17] image.py: write bitbake variables to .env file Ed Bartosh
2015-08-25 9:04 ` [PATCH 02/17] oe-selftest: test generation of <image>.env Ed Bartosh
2015-08-25 9:04 ` [PATCH 03/17] wic: remove undescore from function name Ed Bartosh
2015-08-25 9:04 ` [PATCH 04/17] wic: add BitbakeVars class Ed Bartosh
2015-08-25 9:04 ` [PATCH 05/17] wic: create new method _parse_line Ed Bartosh
2015-08-25 9:04 ` [PATCH 06/17] wic: add default_image attribute to BitbakeVars Ed Bartosh
2015-08-25 9:04 ` [PATCH 07/17] wic: set default image Ed Bartosh
2015-08-25 9:04 ` [PATCH 08/17] wic: implement getting variables from .env files Ed Bartosh
2015-08-25 9:04 ` [PATCH 09/17] wic: implement --vars option Ed Bartosh
2015-08-25 9:04 ` [PATCH 10/17] wic: rename variable Ed Bartosh
2015-08-25 9:04 ` [PATCH 11/17] wic: deferred call of hlp.get_wic_plugins_help() Ed Bartosh
2015-08-25 9:04 ` [PATCH 12/17] image_types.bbclass: add wic image type Ed Bartosh
2015-08-25 17:46 ` Ahsan, Noor
2015-08-26 15:54 ` Ed Bartosh [this message]
2015-08-25 9:04 ` [PATCH 13/17] wic-image-minimal: add wic image recipe and .wks Ed Bartosh
2015-08-25 9:04 ` [PATCH 14/17] oe-selftest: test building wic image by bitbake Ed Bartosh
2015-08-25 9:04 ` [PATCH 15/17] image.py: set bitbake variable ROOTFS_SIZE Ed Bartosh
2015-08-25 9:04 ` [PATCH 16/17] wic: use " Ed Bartosh
2015-08-25 9:04 ` [PATCH 17/17] image.py: add script output to the rootfs log Ed Bartosh
-- strict thread matches above, loose matches on Subject: below --
2015-08-20 11:56 [PATCH 00/17] Build wic images with bitbake Ed Bartosh
2015-08-20 11:56 ` [PATCH 12/17] image_types.bbclass: add wic image type Ed Bartosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826155453.GA17207@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=Noor_Ahsan@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox