Re: [PATCH] webkitgtk: add REQUIRED_DISTRO_FEATURES

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1833 bytes --]

On Tue, Sep 22, 2015 at 02:12:36PM +0300, alexander.kanavin@linux.intel.com wrote:
> > Remove x11 from DISTRO_FEATURES ("I'm building a product that doesn't need
> > or use X") and build webkitgtk.  webkitgtk depends on libxt which depends
> > on libx11 which then refuses to build because you explicitly said you
> > didn't want X.
> >
> > We're adding required_distro_feature annotations as required so that world
> > builds without X11 enabled still work by skipping the recipes instead of
> > failing to build.
> 
> 
> But this means you need to add this to every recipe that directly or
> indirectly depends on libx11. Which is crazy awkward and error-prone.

And was already done:
http://git.openembedded.org/openembedded-core/commit/?id=78d269fa9a586e24ef058ba5315c696f15935f56
http://git.openembedded.org/openembedded-core/commit/?id=bc4d051c2fa56acb0479330b4342a39396de30d4
http://git.openembedded.org/openembedded-core/commit/?id=8764282a06fa5f7571c479a5b3b35c7baaad241f
http://git.openembedded.org/openembedded-core/commit/?id=fda535d5b5239b091c79e957f68a45d4eab0ab5d
http://git.openembedded.org/openembedded-core/commit/?id=1cf0245344ce272e7330cfe1b04a0ed7bd18e8f5
http://git.openembedded.org/openembedded-core/commit/?id=fa1d9b518708103b0b2e259aa78f8dd694cfc0d6

and it's not so error-prone, just call "bitbake world" in DISTRO without
x11 in DISTRO_FEATURES and fix all the ERROR: messages at the beginning.

> Why can't the tools figure out which recipes should be excluded from
> builds without explicit annotations?

See discussion around this change on ML and please don't remove stuff
just because you don't know/remember why it was added without at least
using "git blame" to read commit which introduced it.

Thanks

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]